#32 Bug in button

[Tuomas Lähteenmäki]

GWC crash when pressing Estimete signal (>300 samples) in current view or selection Button.

1. Load sample wav.
2. press Estimete signal (>300 samples) in current view or selection Button.
3. program crash.

I know that a track should be selected for the program to do what it should, but I noticed a programming error there. If you don't select a track and go to press a button, the program crashes.
gwc version is 0.22-05. Ubuntu 18.04 LTS.
5.4.0-107-generic #121~18.04.1-Ubuntu SMP Thu Mar 24 17:21:33 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

[Alister Hood]

Thanks very much for the report - we definitely need to avoid crashes, and even though there is no reason to apply the estimate tool to an entire file, it should work anyway.

The crash isn't actually caused by trying to operate on the entire file - it occurs even with just a short selection that extends to the end of the file. And I see that the insert silence tool does the same.

I have fixed a number of bugs where gwc tried to read one sample past the end of the file, and I think this is the same - I found those bugs when testing batch mode, so I obviously never went through the tools that aren't supported in batch mode testing for this issue.

In this case I see we currently have two other implementations of the dethunk function, dethunk_new and dethunk_current, and if I use either of them it doesn't crash. I don't know the history of this code, so I'll need to look at them and decide whether it is better to switch to one of them or to fix the bug in the function we are currently using.

[Alister Hood]

And I see that the insert silence tool does the same.

Actually that only seems to occur testing in WSL, and there are also issues with cut/copy/paste there, which use some of the same underlying functionality, so perhaps it is a Windows problem.

[Tuomas Lähteenmäki]

Testing cut, copy and paste. working in Linux.

[Alister Hood]

I have committed a fix to my stable branch (https://github.com/AlisterH/gwc/tree/stable) - an error message if the selection is too close to the beginning or end of the file. I will probably make another release in the next few weeks.

It would be nice instead to fix it to work even if the selection reaches the beginning or end of the file, but I don't know that it is worth the effort. Users should just avoid trimming the beginning and end of their recordings until they have finished cleaning them.

I determined that:
- the other two dethunk implementations are older, so presumably not as good.
- although the other two dethunk implementations work right to the end of the recording, I'm not convinced that their results are sane when they do.

[Tuomas Lähteenmäki]

cannot test stable branch. https://github.com/AlisterH/gwc/tree/stable
There is no configure files to building program in linux?

[Alister Hood]

For the record, as per the README: autoreconf -i

configure is a generated file, so it is bad practice to include it in git.
make dist packages it up in the source releases.

When I was cherry-picking from master to create the stable branch, for some reason I missed the commit that made this more prominent in the README. I have added it now.