Menu

#63 UI files loaded from (current dir)/..

open
nobody
None
1
2013-02-02
2012-09-24
No

UI files are loaded from (current dir)/.. which is not safe, and might be wrong (sometimes libraries are in the prefix and not in prefix/bin in Windows). GLib provides a function for use in this occasion, which is what GNOME libraries (like Glade, GLib, GTK+, etc.) uses to locate data files: g_win32_get_package_installation_directory_of_module. The compiled data dir is used instead in Linux.

I attached a patch to fix this.

1 Attachments

Discussion

1 2 > >> (Page 1 of 2)
  • Arnel A. Borja

    Arnel A. Borja - 2012-09-24

    If you're interested, I also created an installer for Windows for gWaei 3.6.1, though it is still incomplete (doesn't have additional fonts, ...). It doesn't work on Wine though (because of the threads when searching).

     
  • Arnel A. Borja

    Arnel A. Borja - 2012-09-24

    It is tested in Windows XP by the way.

     
  • Zachary Dovel

    Zachary Dovel - 2012-09-24

    Lets see the installer. I have an install creation script, but it takes me forever to creat a windows build on my box. That and I can only create i386 binaries. Honestly, I need to try testing the program with something newer than Windows XP at some point. :)

     
  • Arnel A. Borja

    Arnel A. Borja - 2012-09-25

    I compiled it in Ubuntu Quantal using MinGW-64 cross-compilers. I used the binaries from "https://build.opensuse.org/project/show?project=windows%3Amingw%3Awin32" (OpenSUSE 12.1 builds for 32-bit). I compiled for 32-bit, but it should be possible to compile it too for 64-bit. I tested it in Windows XP and Windows 7. Most functionality works. I haven't tested it much, but some of those things not working are kanjipad and download of dictionaries. Those results to segfaults.

     
  • Arnel A. Borja

    Arnel A. Borja - 2012-09-25

    The sample installer.

     
  • Zachary Dovel

    Zachary Dovel - 2012-09-25

    Hrm. It is running but I can't release an installer yet with those issues. Those were all previously working on windows, but at the moment I am trying to do generic *nix fixes and localizations intead of the Windows port. (Windows was a large part of the reason for some architecture changes I did a bit back.)

    Can you split those into 2 separate patches. The other is already pushed into git.

     
  • Arnel A. Borja

    Arnel A. Borja - 2012-09-26

    Here are the patches, updated. Some of them are already attached to bug reports (0001-Add-package-include-paths-before-adding-local.patch, 0002-Compile-libwaei-with-no-undefined-in-LDFLAGS.patch, 0006-Load-GtkBuilder-files-from-installation-prefix-in-Wi.patch). The changes not pushed in Git in the previous patch are moved to 0007-Load-files-from-installation-prefix-in-Windows.patch with some additional changes. Those changes fixed the problems with kanjipad and downloading of dictionaries. Lots of different problems causes the bug with kanjipad, mostly in paths. An assert causes the bug in downloading of dictionaries (lw_io_filesize in io.c, the cache doesn't exists because the download failed), but I wasn't able to test them properly; I use the WiFi connection of the university but it requires a proxy.
    I will attach here next time the NSIS sources of the installer and scripts to build it, I still need to clean them up because I also them for other installers.

     
  • Arnel A. Borja

    Arnel A. Borja - 2012-09-26

    Latest build of installer.

     
  • Zachary Dovel

    Zachary Dovel - 2012-09-26

    Thank you, Arnel. I appreciate your help. Since I migrated my site to the new sourceforge site, the git repository forked. Unfortunately, my work is still on the old for which is no longer public. I believe I have one fix for the installation of dictionaries in 3.6.1.

     
  • Zachary Dovel

    Zachary Dovel - 2012-09-26

    Okay, I deleted and recreated the public repo po it is accessable at "git clone git://git.code.sf.net/p/gwaei/code gwaei-code"

     
  • Arnel A. Borja

    Arnel A. Borja - 2012-09-27

    Seems like download in Windows still doesn't work :(. I tested it just know on a Windows XP. I'll try debugging it on weekends.

     
  • Arnel A. Borja

    Arnel A. Borja - 2012-10-01

    Latest build of installer. The only remaining problem is that the 'favorite' (?) icon in the Dictionaries section of Preferences is not properly loaded and kanji-stroke-orders font is not installed.

     
  • Zachary Dovel

    Zachary Dovel - 2012-10-02

    I just included the favorite icon from the gnome icon theme in the installer as well as the save icon for when you install dictioniaries. Your patched have been reviewed and applied to the git repo. :D I should have cought the url separator problem for win32.

     
  • Zachary Dovel

    Zachary Dovel - 2012-10-02

    once you have those two things in I'll check it and post the installer. ;) thank for the help again

     
  • Zachary Dovel

    Zachary Dovel - 2012-10-02

    Also, for some reason I haven't been able to get gWaei to use a the native Win32 theme on Windows yet. It was supposed to be integrated in gtk3.4, but I don't know if I believe it.

     
  • Arnel A. Borja

    Arnel A. Borja - 2012-10-03

    If gtk-theme-name is not set in etc/gtk-3.0/settings.ini (or GTK+ cannot find the theme specified), it will automatically use the Windows theme. The last time I checked, the buttons are a bit larger and the menus are a bit smaller.

     
  • Arnel A. Borja

    Arnel A. Borja - 2012-10-10

    I fixed the icons by including the Gnome icon theme (increasing the size ~10mb), and added the KanjiStrokeOrders font (adding another ~10mb). The install size is now about ~78mb.

    I also fixed the lockup in Wine which also happens in Windows sometimes.

    I made a lot of changes to the installer, it's best to uninstall the old one first. Also, the older ones might have left some files in your "Program Files" folder, in "Zachary Dovel" and "gWaei" folders. The installation directory is back to "Program Files/gWaei".

    I included the manual too in the installer. Seems like there's a missing icon in the manual named "share/gwaei/character.png" and it's not in the tarball either. Is it "share/gwaei/unknown-character.png"?

    I included translations in the installer. If you want to translate it (i.e. in Japanese), you could edit the script file then attach it here so that I could fix the installer. Open them in gEdit with "Japanese (CP932)" character encoding (it is in the lower left of "Open Files" dialog when you click the "Open" button in the toolbar, select "Add or Remove" first to add in the list if it not available). There are also some strings in the Multi-User page and font installation not yet translated, I will post the strings here too so that you could attach a text file with the translations in the same encoding if you want to translate them. You could also add other languages. Feel free to change the descriptions of the installer sections, I just added some simple descriptions. Note that it seems gWaei's translations itself doesn't work yet, I'm still looking for the problem though it seems like it's because MinGW and Linux uses different file format for PO files (different libraries are used for gettext in Windows and Linux, because of some license issues). Also, I only know some Japanese words and simple Japanese grammar, so I cannot translate them myself (I use gWaei to study Japanese on my own).

    I wasn't able to fix them because I have some exams last week.

     

    Last edit: Arnel A. Borja 2012-10-10
  • Arnel A. Borja

    Arnel A. Borja - 2012-10-10

    Multi-User translatable strings.

    !ifdef MULTIUSER_INSTALLMODEPAGE
    ${LangFileString} MULTIUSER_TEXT_INSTALLMODE_TITLE "Choose Users"
    ${LangFileString} MULTIUSER_TEXT_INSTALLMODE_SUBTITLE "Choose for which users you want to install $(^NameDA)."
    ${LangFileString} MULTIUSER_INNERTEXT_INSTALLMODE_TOP "Select whether you want to install $(^NameDA) for yourself only or for all users of this computer. $(^ClickNext)"
    ${LangFileString} MULTIUSER_INNERTEXT_INSTALLMODE_ALLUSERS "Install for anyone using this computer"
    ${LangFileString} MULTIUSER_INNERTEXT_INSTALLMODE_CURRENTUSER "Install just for me"
    !endif

     
  • Arnel A. Borja

    Arnel A. Borja - 2012-10-10

    Font plugin translatable strings

    Push "Wrong Font Version"
    Push "MappedFile Address Error: %u"
    Push "MappedFile Error: %u"
    Push "Invalid file size: %u"
    Push "Invalid file handle %u"
    Push "FontName %s plugin for NSIS"

     
  • Arnel A. Borja

    Arnel A. Borja - 2012-10-10

    Latest NSIS script with translatable strings.

    Please attach the new file edited in a post here if you want to translate the installer. Other translatable strings in another text file. All files in CP932 character encoding.

    (Ignore the Mobilect Payroll script, I can't remove it)

     

    Last edit: Arnel A. Borja 2012-10-10
  • Arnel A. Borja

    Arnel A. Borja - 2012-10-10

    Patch to fix compilation without mecab in path (does mecab doesn't really work in Windows? I tried compiling gWaei with mecab before, without success, has some segmentation faults).

     
1 2 > >> (Page 1 of 2)

Log in to post a comment.

MongoDB Logo MongoDB