Re: [Gtodo-list] Segfault in export.c

[Qball C. <qb...@qb...>]

Patch looks fine. if you want direct commit access contact me.

Qball

On Sat, 2007-02-10 at 19:28 +0100, wwp wrote:
> Hi Qball,
> 
> 
> there's a crash I reproduce every time here, it's when exporting to HTML, if
> Embed Default CSS is checked (1st checkbox) and if Export Current Cat only is
> checked too (last checkbox). Here's a quick patch against current SVN that
> does check for pointer sanity, maybe not exactly what you'd like but it does
> the fix to me:
> 
> Index: src/export.c
> ===================================================================
> --- src/export.c        (revision 8)
> +++ src/export.c        (working copy)
> @@ -207,7 +207,7 @@
>         if(gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(cb_curcat)))
>         {
>                 int i= 0, cat = 0;
> -               for(i=0;param_string[i] != NULL;i++);
> +               for(i=0;param_string && param_string[i] != NULL;i++);
>                 cat = gtk_option_menu_get_history (GTK_OPTION_MENU (mw.option));
> 
>                 if(cat != 0)
> 
> 
> BTW, do you think that exporting to HTML could keep the current sort method?
> 
> 
> Regards,
> 
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier.
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________ Gtodo-list mailing list Gto...@li... https://lists.sourceforge.net/lists/listinfo/gtodo-list