Re: [Gtkpod-devel] gtkpod 2.1.4-beta1 released

[Dimstar / D. L. <di...@op...>]

On Sam, 2013-08-24 at 23:03 +0100, phantomjinx wrote: 
> Evening people,
> 
> 2.1.4-beta1 out the door and uploaded ...
> 
> Changelog and NEWS have the details.

Hi,

I tried building gtkpod 2.1.4beta1 against GNOME 3.9.90;
The first issue encountered is the deprecation of GtkStock, which you
still seem to be making use of:

[   19s] gtkpod_app_iface.c: In function 'ok_to_close_gtkpod':
[   19s] gtkpod_app_iface.c:152:104: error: 'GTK_STOCK_SAVE' undeclared
(first use in this function)
[   19s]                  = gtkpod_confirmation_hig(GTK_MESSAGE_WARNING,
_("Save changes before quiting?"), str, GTK_STOCK_SAVE,
GTK_STOCK_CANCEL, _("Quit without saving"), NULL);
[   19s]
^
[   19s] gtkpod_app_iface.c:152:104: note: each undeclared identifier is
reported only once for each function it appears in
[   19s] gtkpod_app_iface.c:152:120: error: 'GTK_STOCK_CANCEL'
undeclared (first use in this function)
[   19s]                  = gtkpod_confirmation_hig(GTK_MESSAGE_WARNING,
_("Save changes before quiting?"), str, GTK_STOCK_SAVE,
GTK_STOCK_CANCEL, _("Quit without saving"), NULL);
[   19s]
^
[   19s] gtkpod_app_iface.c: In function
'gtkpod_display_command_ctx_menu':
[   19s] gtkpod_app_iface.c:611:61: error: 'GTK_STOCK_EXECUTE'
undeclared (first use in this function)
[   19s]          hookup_menu_item(menu, track_command_get_text(cmd),
GTK_STOCK_EXECUTE, G_CALLBACK (on_track_command_menuitem_activate),
pairarr);
[   19s]                                                              ^
[   19s] make[2]: *** [gtkpod_app_iface.lo] Error 1
[   19s] make[2]: Leaving directory
`/home/abuild/rpmbuild/BUILD/gtkpod-2.1.4/libgtkpod'

Hacking -DGTK_DISABLE_DEPRECATED out of configure gets me over this (but
I don't think this should be needed for a release).

With this done, the build fails further down with:
[   48s] gtkpod.c: In function 'on_gtkpod_delete_event':
[   48s] gtkpod.c:245:35: error: 'profile_manager' undeclared (first use
in this function)
[   48s]      anjuta_profile_manager_close (profile_manager);
[   48s]                                    ^

Cheers,
Dominique
-- 
Dimstar / Dominique Leuenberger <di...@op...>