Re: [Gtkpod-devel] Patches: mp4 chapters, sorting/compilation/media type tags

[Joel S. <jsf...@jk...>]

On 11/11/2012 03:09 AM, Daniele Forsi wrote:
> I don't know that code but in this commit
> https://gitorious.org/~joelsmith/gtkpod/joelsmiths-sandbox/commit/6157a8c10646ff25c98651755c6dbbafa63170ba
>
> you are using g_strdup() while existing code uses charset_to_utf8()
>
> exisitng code:
> 182        // MP4 Title
> 183	        value = find_atom_value(TITLE);
> 184	        if (value) {
> 185	            track->title = charset_to_utf8(value);
> 186	            free(value);
> 187	        }
>
> new code:
> 383        // MP4 Sort Title
> 384	        value = find_atom_value(SORT_TITLE);
> 385	        if (value) {
> 386	            track->sort_title = g_strdup(value);
> 387	            free(value);
> 388	        }
>
> if that's ok can you please explain why with a comment in the code?

I think the existing code is wrong.  MP4 tags are already stored as 
UTF-8 (or at least they're supposed to be).  And AP doesn't do any 
further conversions before returning the strings to us, so we shouldn't 
be trying to convert an already UTF-8 string from local charset to 
UTF-8.  If run with a non-UTF-8 charset locale, that would corrupt the 
data.  For example, with ISO-8859-1, all but the lower 128 char values 
would get corrupted.  Funny that I didn't even notice the other ones 
doing it wrong. Thanks for reviewing the patch so we could catch the 
other bug. I'll commit a fix. I'm no expert on i18n, charsets, etc, so 
maybe we'll end up reverting my change right away, but that's how I see it.
Regards,
Joel