Re: [Gtkpod-devel] [gtpd-cvs] [gtkpod] add mp4 chapter reading support to Atomic Parsley bridge

[Joel S. <jsf...@jk...>]

On 11/11/2012 03:26 AM, Daniele Forsi wrote:
> can we make that title translatable?
> title = g_strdup_printf(_("Chapter %3d"), i);
> and since translators will see the comments above that line, I'd
> change them a bit, something like:
> // Translators: this string is used to create a title when chapter
> title couldn't be found
> // (some iPods don't display them anyway)
>
> is this related to a specific media or it could be anything (music,
> movies, audiobooks)?
> Not a big deal, but in Italian I would translate "chapter" differently
> when it is related to music WRT other types

The chapters are not specific to any type of media. I expect that 
they're most common with movies and audiobooks, but you can put them on 
any audio or video track.

With that in mind, it isn't terribly important anyways... this code will 
only get hit if somebody has a malformed chapter in their MP4 atom 
data.  Basically, there are 3 parts that we need in order to get the 
chapter info.  But only the first one is crucial (the chapter 
duration).  The other two are the strlen of the chapter name and the 
seek offset for the chapter name.  It's only if one or both of those two 
are missing that we try to invent our own chapter names.  But I've never 
actually seen an MP4 file with broken atom data such that this code 
would get used. It's only there to keep us from getting crashy if we do 
run into such a file.

I'll make the suggested change and commit it.
Regards,
Joel