Re: [Gtkpod-devel] Patches: mp4 chapters, sorting/compilation/media type tags

[Daniele F. <df...@gm...>]

2012/11/9 Joel Smith:

> I have added some patches to the Atomic Parsley wrapper to get support
> for reading MP4 Quicktime-style chapters and reading/writing some
> missing tags, such as the sorting tags.

I don't know that code but in this commit
https://gitorious.org/~joelsmith/gtkpod/joelsmiths-sandbox/commit/6157a8c10646ff25c98651755c6dbbafa63170ba

you are using g_strdup() while existing code uses charset_to_utf8()

exisitng code:
182        // MP4 Title
183	        value = find_atom_value(TITLE);
184	        if (value) {
185	            track->title = charset_to_utf8(value);
186	            free(value);
187	        }

new code:
383        // MP4 Sort Title
384	        value = find_atom_value(SORT_TITLE);
385	        if (value) {
386	            track->sort_title = g_strdup(value);
387	            free(value);
388	        }

if that's ok can you please explain why with a comment in the code?
-- 
Daniele Forsi