Re: [Gtkpod-devel] Patches: mp4 chapters, sorting/compilation/media type tags

[Joel S. <jsf...@jk...>]

On 11/10/2012 02:34 PM, phantomjinx wrote:
> Hi Joel,
>
> When you are ready can you push your patches onto sf. I would like to roll them into the 2.1.3 release.
>
> Any idea whether your patches would solve [1]?
>
> Cheers
>
> PGR
>
> [1] https://sourceforge.net/tracker/index.php?func=detail&aid=3575205&group_id=67873&atid=519273
>
>

Hi PGR,
I had forgotten that I had commit access on sf. I'll push soon. 
Regarding [1] above, I had tested all the tags and not found any 
problems other than the ones I fixed, but after reading the bug report, 
I looked into it.  It looks like that's an Atomic Parseley bug where if 
you have a tempo above 99 BPM,  it won't fit into the malloc'd buffer 
that sprintf() is using for its output. (The buffer is size 4 and after 
the \n and the \0, any tempo of more than 2 digits will overflow the 
buffer). I'll make a fix and push that too.
Regards,
Joel