Re: [Gtkpod-devel] Some more leaks from valgrind

[Andrea <mar...@go...>]

Tomas Carnecky wrote:
> Andrea wrote:
>> Here is a patch to fix some more leaks.
>>
>> One of them is actually to remove a false positive when valgrind detects 
>> use of uninitialized data (basically it avoids calling fopen with a NULL 
>> filename).
> 
> Index: src/display.c
> ===================================================================
> --- src/display.c	(revision 2096)
> +++ src/display.c	(working copy)
> @@ -565,6 +565,7 @@
>   	gchar *resvalues = (gchar *) g_malloc (sizeof(gint) + (sizeof(gchar) 
> * 3) + sizeof(gint));
>   	g_sprintf (resvalues, "%d x %d", pixwidth, pixheight);
>   	text = g_markup_printf_escaped (_("<b>Image Dimensions: %s</b>"), 
> resvalues);
> +	g_free (resvalues);
>   	gtk_label_set_markup (GTK_LABEL (res_label), text);
>   	g_free (text);
> 
> 
> Why not simply:
> 
> text = g_markup_printf_escaped (_("<b>Image Dimensions: %d x %d</b>"), 
> pixwidth, pixheight);
> 
> so you can get rid of resvalues?

Looks fine to me.

Andrea