Thread: [Gtkpod-devel] [GIT PULL] UI fixes, code cleanup

Brought to you by: jcsjcs, phantom_sf, teuf, tmzullinger

gtkpod-devel

[Gtkpod-devel] [GIT PULL] UI fixes, code cleanup

From: Jonathan N. <j.n...@gm...> - 2013-05-31 19:18:35

Hello developers,

please consider pulling my gtkpod fixes from:

	git://github.com/neuschaefer/gtkpod.git ui

The commits are:

  display_playlists: balance parentheses in a comment
  display_playlists: remove outdated debugging printfs
  playlist_display: support dropping playlist into an itdb
  playlist_display: remove a comment about "SPL data"
  playlist_display: reduce duplicate code
  fix "Unknown option: (null)" on --misspelled-option
  usage: avoid the translation of args
  usage: improve output style

libgtkpod/prefs.c                            |   19 ++--
plugins/playlist_display/display_playlists.c |   99 +++++++------------
2 files changed, 47 insertions(+), 71 deletions(-)


Best regards,
Jonathan Neuschäfer

Re: [Gtkpod-devel] [GIT PULL] UI fixes, code cleanup

From: Jonathan N. <j.n...@gm...> - 2013-05-31 20:31:18

(CC'ing gtkpod-devel)

On Fri, May 31, 2013 at 09:46:39PM +0200, Daniele Forsi wrote:
> 2013/5/31 Jonathan Neuschäfer:
> 
> >   usage: avoid the translation of args
> 
> I only looked at this commit and I'd suggest not to apply it because
> without args translators can't easily align the descriptions (if they
> want)

Agreed, drop this patch.

But we will have to watch out that translators don't translate the
option names, as it happened in po/de.po:

  #: ../libgtkpod/prefs.c:328
  msgid "  --mountpoint: same as '-m'.\n"
  msgstr "  --Einhängepunkt: wie '-m'.\n"

Luckily, it's the only case throughout po/.


Thanks,
Jonathan Neuschäfer

[Gtkpod-devel] [PATCH] po/de.po: untranslate --mountpoint

From: Jonathan N. <j.n...@gm...> - 2013-05-31 20:43:06

---
 po/de.po |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/po/de.po b/po/de.po
index be89d1c..a881a47 100644
--- a/po/de.po
+++ b/po/de.po
@@ -2315,7 +2315,7 @@ msgstr "  -m <Pfad>:    Einhängepunkt für iPod angeben\n"
 
 #: ../libgtkpod/prefs.c:328
 msgid "  --mountpoint: same as '-m'.\n"
-msgstr "  --Einhängepunkt: wie '-m'.\n"
+msgstr "  --mountpoint: wie '-m'.\n"
 
 #: ../libgtkpod/prefs.c:496
 #, c-format
-- 
1.7.10.4

Re: [Gtkpod-devel] [PATCH] po/de.po: untranslate --mountpoint

From: Daniele F. <df...@gm...> - 2013-06-01 18:06:12

2013/5/31 Jonathan Neuschäfer <j.n...@gm...>:
> ---
>  po/de.po |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/po/de.po b/po/de.po
> index be89d1c..a881a47 100644
> --- a/po/de.po
> +++ b/po/de.po
> @@ -2315,7 +2315,7 @@ msgstr "  -m <Pfad>:    Einhängepunkt für iPod angeben\n"
>
>  #: ../libgtkpod/prefs.c:328
>  msgid "  --mountpoint: same as '-m'.\n"
> -msgstr "  --Einhängepunkt: wie '-m'.\n"
> +msgstr "  --mountpoint: wie '-m'.\n"
>
>  #: ../libgtkpod/prefs.c:496
>  #, c-format
> --
> 1.7.10.4
>

pushed, thank you

however I noticed now that gtkpod --help doesn't show that string and
the other usage strings from libgtkpod/prefs.c because --help is
intercepted by g_option_context_parse() in src/main.c

using GOption also for prefs.c would avoid translation of arguments
and fix the formatting...

-- 
Daniele Forsi

Re: [Gtkpod-devel] [PATCH] po/de.po: untranslate --mountpoint

From: Jonathan N. <j.n...@gm...> - 2013-06-03 08:26:21

On Sat, Jun 01, 2013 at 08:06:00PM +0200, Daniele Forsi wrote:
> however I noticed now that gtkpod --help doesn't show that string and
> the other usage strings from libgtkpod/prefs.c because --help is
> intercepted by g_option_context_parse() in src/main.c
> 
> using GOption also for prefs.c would avoid translation of arguments
> and fix the formatting...

Thank you for the hint, I'm working on it now.


Regards,
Jonathan Neuschäfer

[Gtkpod-devel] [GIT PULL v2] UI fixes, code cleanup

From: Jonathan N. <j.n...@gm...> - 2013-06-03 08:40:12

Hi,

I've updated my previous patchset. The updated version is available at:

	git://github.com/neuschaefer/gtkpod.git ui.v2

The commits are:

  display_playlists: balance parentheses in a comment
  display_playlists: remove outdated debugging printfs
  playlist_display: support dropping playlist into an itdb
  playlist_display: remove a comment about "SPL data"
  playlist_display: reduce duplicate code

plugins/playlist_display/display_playlists.c |   99 ++++++------------
1 file changed, 34 insertions(+), 65 deletions(-)


Best regards,
Jonathan Neuschäfer

Re: [Gtkpod-devel] [GIT PULL v2] UI fixes, code cleanup

From: phantomjinx <p.g...@ph...> - 2013-06-20 15:18:25

Not sure this has been merged yet. Is it ready to be?

PGR

On 06/03/2013 09:40 AM, Jonathan Neuschäfer wrote:
> Hi,
> 
> I've updated my previous patchset. The updated version is available at:
> 
> 	git://github.com/neuschaefer/gtkpod.git ui.v2
> 
> The commits are:
> 
>   display_playlists: balance parentheses in a comment
>   display_playlists: remove outdated debugging printfs
>   playlist_display: support dropping playlist into an itdb
>   playlist_display: remove a comment about "SPL data"
>   playlist_display: reduce duplicate code
> 
> plugins/playlist_display/display_playlists.c |   99 ++++++------------
> 1 file changed, 34 insertions(+), 65 deletions(-)
> 
> 
> Best regards,
> Jonathan Neuschäfer
> 
> ------------------------------------------------------------------------------
> Get 100% visibility into Java/.NET code with AppDynamics Lite
> It's a free troubleshooting tool designed for production
> Get down to code-level detail for bottlenecks, with <2% overhead.
> Download for free and get started troubleshooting in minutes.
> http://p.sf.net/sfu/appdyn_d2d_ap2
> _______________________________________________
> Gtkpod-devel mailing list
> Gtk...@li...
> https://lists.sourceforge.net/lists/listinfo/gtkpod-devel
> 

-- 
Paul Richardson

  * p.g...@ph...
  * p.g...@re...
  * pgr...@li...

"I know exactly who reads the papers ...

  * The Daily Mirror is read by people who think they run the country.
  * The Guardian is read by people who think they ought to run the country.
  * The Times is read by people who do actually run the country.
  * The Daily Mail is read by the wives of the people who run the country.
  * The Financial Times is read by the people who own the country.
  * The Morning Star is read by the people who think the country ought to be run by another country.
  * The Daily Telegraph is read by the people who think it is."

Jim Hacker, Yes Minister

Re: [Gtkpod-devel] [GIT PULL v2] UI fixes, code cleanup

From: Jonathan N. <j.n...@gm...> - 2013-06-20 15:54:33

On Thu, Jun 20, 2013 at 04:18:16PM +0100, phantomjinx wrote:
> Not sure this has been merged yet. Is it ready to be?

Yes, correct.  It will merge and build cleanly.


Thanks,
Jonathan

[...]
> >   display_playlists: balance parentheses in a comment
> >   display_playlists: remove outdated debugging printfs
> >   playlist_display: support dropping playlist into an itdb
> >   playlist_display: remove a comment about "SPL data"
> >   playlist_display: reduce duplicate code
> > 
> > plugins/playlist_display/display_playlists.c |   99 ++++++------------
> > 1 file changed, 34 insertions(+), 65 deletions(-)
[...]

Re: [Gtkpod-devel] [GIT PULL v2] UI fixes, code cleanup

From: phantomjinx <p.g...@ph...> - 2013-06-20 18:50:07

merged.

On 06/20/2013 04:54 PM, Jonathan Neuschäfer wrote:
> On Thu, Jun 20, 2013 at 04:18:16PM +0100, phantomjinx wrote:
>> Not sure this has been merged yet. Is it ready to be?
> 
> Yes, correct.  It will merge and build cleanly.
> 
> 
> Thanks,
> Jonathan
> 
> [...]
>>>   display_playlists: balance parentheses in a comment
>>>   display_playlists: remove outdated debugging printfs
>>>   playlist_display: support dropping playlist into an itdb
>>>   playlist_display: remove a comment about "SPL data"
>>>   playlist_display: reduce duplicate code
>>>
>>> plugins/playlist_display/display_playlists.c |   99 ++++++------------
>>> 1 file changed, 34 insertions(+), 65 deletions(-)
> [...]
> 
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
> 
> Build for Windows Store.
> 
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Gtkpod-devel mailing list
> Gtk...@li...
> https://lists.sourceforge.net/lists/listinfo/gtkpod-devel
> 

-- 
Paul Richardson

  * p.g...@ph...
  * p.g...@re...
  * pgr...@li...

"I know exactly who reads the papers ...

  * The Daily Mirror is read by people who think they run the country.
  * The Guardian is read by people who think they ought to run the country.
  * The Times is read by people who do actually run the country.
  * The Daily Mail is read by the wives of the people who run the country.
  * The Financial Times is read by the people who own the country.
  * The Morning Star is read by the people who think the country ought to be run by another country.
  * The Daily Telegraph is read by the people who think it is."

Jim Hacker, Yes Minister