From: Todd Z. <tm...@po...> - 2008-07-30 15:53:00
|
Looking at Itdb_Track recently I wondered if chapterdata_raw and chapterdata_raw_length can safely be removed. I don't think they are used anywhere now that chapter data support is available. But since I don't have any tracks that use chapter data, I didn't feel I was able to test this theory properly. Would anyone that uses chapter data support care to test and report whether the attached patch breaks things? -- Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ A fool's brain digests philosophy into folly, science into superstition, and art into pedantry. Hence University education. -- George Bernard Shaw |
From: Michael T. <ti...@ti...> - 2008-07-31 23:52:28
|
On Wed, 2008-07-30 at 11:52 -0400, Todd Zullinger wrote: > Looking at Itdb_Track recently I wondered if chapterdata_raw and > chapterdata_raw_length can safely be removed. I don't think they are > used anywhere now that chapter data support is available. But since I > don't have any tracks that use chapter data, I didn't feel I was able > to test this theory properly. > > Would anyone that uses chapter data support care to test and report > whether the attached patch breaks things? That should work just fine, but I haven't tested it yet. I don't remember why I left those variables in there (python bindings, maybe?), but they shouldn't be used by anything anymore. Next time I move over some movies I'll try to remember to check it out and make sure. Michael -- Michael Tiffany ti...@ti... http://www.tiffman.com |
From: Todd Z. <tm...@po...> - 2008-11-14 16:43:52
|
Hi Michael, Michael Tiffany wrote: > On Wed, 2008-07-30 at 11:52 -0400, Todd Zullinger wrote: That should > work just fine, but I haven't tested it yet. I don't remember why I > left those variables in there (python bindings, maybe?), but they > shouldn't be used by anything anymore. Next time I move over some > movies I'll try to remember to check it out and make sure. Have you had a change to try out libgpod with the chapterdata_raw parts removed? A new release is approaching and it'd be nice to remove those if they are just cruft. :) Patch is attached again, in case you don't have the old thread at hand. -- Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ To err is human; to blame it on somebody else is even more human. -- John Nadeau |