From: Jonathan N. <j.n...@gm...> - 2012-12-20 12:17:27
|
With this patchset I fix three cases in which Gtkpod could crash. It is also available on github: https://github.com/neuschaefer/gtkpod/commits/dev Patches: * de9884f track_display: handle gtkpod_get_current_playlist() == NULL * 6323646 coverart: fix a crash on missing artist names * 09b7b9d playlist_display: prevent a double-free Thanks, Jonathan Neuschäfer |
From: Jonathan N. <j.n...@gm...> - 2012-12-20 12:15:35
|
--- plugins/track_display/display_tracks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/track_display/display_tracks.c b/plugins/track_display/display_tracks.c index 122e3a8..be57bff 100644 --- a/plugins/track_display/display_tracks.c +++ b/plugins/track_display/display_tracks.c @@ -1157,7 +1157,7 @@ static void tm_adopt_order(GList *tracks) { * list. */ Playlist *cp = gtkpod_get_current_playlist(); - GList *pt = cp->members; + GList *pt = cp? cp->members : NULL; GtkTreeModel *model = gtk_tree_view_get_model(track_treeview); while (pt != NULL) { Track *track = pt->data; -- 1.7.10.4 |
From: Jonathan N. <j.n...@gm...> - 2012-12-20 12:15:41
|
--- plugins/cover_display/display_coverart.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/plugins/cover_display/display_coverart.c b/plugins/cover_display/display_coverart.c index f981817..e3b8dcb 100644 --- a/plugins/cover_display/display_coverart.c +++ b/plugins/cover_display/display_coverart.c @@ -533,9 +533,11 @@ void coverart_display_update(gboolean clear_track_list) { while (tracks) { gchar *album_key; + gchar *artist_name; track = tracks->data; - album_key = g_strconcat(track->artist, "_", track->album, NULL); + artist_name = track->artist? track->artist : ""; + album_key = g_strconcat(artist_name, "_", track->album, NULL); /* Check whether an album item has already been created in connection * with the track's artist and album */ -- 1.7.10.4 |
From: Jonathan N. <j.n...@gm...> - 2012-12-20 12:17:28
|
This crash could previously be triggered by dragging a newly created (and not yet saved) playlist from one local repository to another. --- plugins/playlist_display/display_playlists.c | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/playlist_display/display_playlists.c b/plugins/playlist_display/display_playlists.c index 380834e..f2d1300 100644 --- a/plugins/playlist_display/display_playlists.c +++ b/plugins/playlist_display/display_playlists.c @@ -765,6 +765,7 @@ static void pm_drag_data_received(GtkWidget *widget, GdkDragContext *dc, gint x, if (pos == GTK_TREE_VIEW_DROP_AFTER) pl_d = gp_playlist_add_new(pl->itdb, pl_s->name, FALSE, position + 1); g_free(data_copy); + data_copy = NULL; g_return_if_fail (pl_d); /* copy files from iPod if necessary */ -- 1.7.10.4 |
From: Jonathan N. <j.n...@gm...> - 2013-01-06 00:36:41
|
Phantomjinx, please consider including this patchset in 2.1.4: On Thu, Dec 20, 2012 at 01:08:25PM +0100, Jonathan Neuschäfer wrote: > With this patchset I fix three cases in which Gtkpod could crash. > It is also available on github: > > https://github.com/neuschaefer/gtkpod/commits/dev > > Patches: > * de9884f track_display: handle gtkpod_get_current_playlist() == NULL > * 6323646 coverart: fix a crash on missing artist names > * 09b7b9d playlist_display: prevent a double-free Thanks, Jonathan Neuschäfer |
From: phantomjinx <p.g...@ph...> - 2013-01-06 04:29:58
|
"Jonathan Neuschäfer" <j.n...@gm...> wrote: >Phantomjinx, > >please consider including this patchset in 2.1.4: > >On Thu, Dec 20, 2012 at 01:08:25PM +0100, Jonathan Neuschäfer wrote: >> With this patchset I fix three cases in which Gtkpod could crash. >> It is also available on github: >> >> https://github.com/neuschaefer/gtkpod/commits/dev >> >> Patches: >> * de9884f track_display: handle gtkpod_get_current_playlist() == NULL >> * 6323646 coverart: fix a crash on missing artist names >> * 09b7b9d playlist_display: prevent a double-free > > >Thanks, >Jonathan Neuschäfer > >------------------------------------------------------------------------------ >Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, >MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current >with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft >MVPs and experts. ON SALE this month only -- learn more at: >http://p.sf.net/sfu/learnmore_123012 >_______________________________________________ >Gtkpod-devel mailing list >Gtk...@li... >https://lists.sourceforge.net/lists/listinfo/gtkpod-devel Hi Jonathan, I did send you a message regarding these patches last night with an apology for not including them in 2.1.3. Did you not get it? Did you want gtkpod commit access? Thanks for your efforts. PGR |
From: Jonathan N. <j.n...@gm...> - 2013-01-06 07:37:51
|
On Sun, Jan 06, 2013 at 04:29:45AM +0000, phantomjinx wrote: > "Jonathan Neuschäfer" <j.n...@gm...> wrote: > > >Phantomjinx, > > > >please consider including this patchset in 2.1.4: > > > >On Thu, Dec 20, 2012 at 01:08:25PM +0100, Jonathan Neuschäfer wrote: > >> With this patchset I fix three cases in which Gtkpod could crash. > >> It is also available on github: > >> > >> https://github.com/neuschaefer/gtkpod/commits/dev > >> > >> Patches: > >> * de9884f track_display: handle gtkpod_get_current_playlist() == NULL > >> * 6323646 coverart: fix a crash on missing artist names > >> * 09b7b9d playlist_display: prevent a double-free > > > > > >Thanks, > >Jonathan Neuschäfer > > > > Hi Jonathan, > > I did send you a message regarding these patches last night with an apology for not including them in 2.1.3. Did you not get it? Not then, but now I did. > Did you want gtkpod commit access? Yes, but I'd still like to post patches for discussion, to keep to somewhat informed about what I'm doing (you could read the git log, too, sure, but I like discussing things). I've contacted you on sourceforge, now. Jonathan > > Thanks for your efforts. > > PGR |