commit 04b931cd04e8672b0dcfde0bb09a47260efacbff
Author: phantomjinx <p.g...@ph...>
Date: Sat Oct 6 20:54:44 2012 +0100
Fix for error caught by turning on error=format-security
* configure.ac
* Leave error trapping switched on to trap further errors.
* Thanks to Brent <we...@ai...> for the report and fix.
configure.ac | 2 +-
plugins/clarity/clarity_cover.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/configure.ac b/configure.ac
index f2d83c7..692a78f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -124,7 +124,7 @@ dnl else
dnl fi
dnl Force C99 mode (no implicit int declarations)
-CFLAGS="$CFLAGS -std=gnu99 -Werror-implicit-function-declaration"
+CFLAGS="$CFLAGS -std=gnu99 -Werror-implicit-function-declaration -Werror=format-security"
CFLAGS="$CFLAGS $GTK_CFLAGS $GLIB_CFLAGS $GDK_CFLAGS $GMODULE_CFLAGS $GTHREAD_CFLAGS $LIBGLADE_CFLAGS $LIBGPOD_CFLAGS $LIBANJUTA_CFLAGS $LIBGDL_CFLAGS $LIBXML_CFLAGS $ID3TAG_CFLAGS $GTK_CLEANLINESS_FLAGS"
LIBS="$LIBS $GTK_LIBS $GLIB_LIBS $GDK_LIBS $GMODULE_LIBS $GTHREAD_LIBS $LIBGLADE_LIBS $LIBGPOD_LIBS $LIBANJUTA_LIBS $LIBGDL_LIBS $LIBXML_LIBS $ID3TAG_LIBS"
diff --git a/plugins/clarity/clarity_cover.c b/plugins/clarity/clarity_cover.c
index 32e3943..68699fd 100644
--- a/plugins/clarity/clarity_cover.c
+++ b/plugins/clarity/clarity_cover.c
@@ -241,7 +241,7 @@ void clarity_cover_set_album_item (ClarityCover *self, AlbumItem *item) {
// Set cover artwork
gtk_clutter_texture_set_from_pixbuf (GTK_CLUTTER_TEXTURE(priv->texture), item->albumart, &error);
if (error) {
- g_warning(error->message);
+ g_warning("%s", error->message);
g_error_free(error);
return;
}
|
