From: <bug...@wi...> - 2003-06-30 23:12:42
|
Please do not reply to this email- if you want to comment on the bug, go to the URL shown below and enter your comments there. http://bugzilla.gnome.org/show_bug.cgi?id=115886 Changed by ds...@sc.... --- shadow/115886 Mon Jun 30 18:00:48 2003 +++ shadow/115886.tmp.14660 Mon Jun 30 19:12:36 2003 @@ -76,6 +76,16 @@ * change the macros to caps->properties != NULL && ..., which is ugly because you should never use variables-in-macros twice, they could be functions * fix this by making the macros inline functions The above patch implements the third fixage method. + +------- Additional Comments From ds...@sc... 2003-06-30 19:12 ------- +I vote for the third option, too. However, they should be real +functions, not inline. We don't do inline functions in headers. + +I mostly got a consensus on IRC that gst_caps_*() code should properly +handle caps==NULL and caps->properties==NULL, but gst_props_*() +functions can expect (and assert) that they are called with props != +NULL. This is because the props code is almost exclusively used by +caps, whereas caps is used by plugins and apps. |