From: Stefan K. <en...@ho...> - 2010-09-07 12:22:05
|
On 07.09.2010 14:33, Olivier Crête wrote: > Hi, > > On Tue, 2010-09-07 at 14:12 +0300, Miguel Verdu wrote: > >> We are planning to add support in our video codecs for the fast update >> commands defined in H.245 recommendation. This is also functionally >> similar to what is required by the RTP/AVPF spec (RFC4585). >> > I've already started to implement RTP/AVPF, code at: > http://git.collabora.co.uk/?p=user/tester/gst-plugins-good.git;a=shortlog;h=refs/heads/avpf-timing > > > >> My current proposal tries to be general enough to cover what is required by >> both recommendations >> >> - New upstream event >> Name: PictureLoss >> Empty stuct >> > There is already a "GstForceKeyUnit" event defined for that, and it is > implemented by most of the relevant open source encoder (x264enc, > gst-ffmpeg and theoraenc) elements. My AVPF branch produces that > GstForceKeyUnit event on the relevant AVPF RTCP messages. > > Documented at: > http://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/docs/design/draft-keyframe-force.txt > > > >> Name: SliceLoss >> Name: ReferencePictureSelection >> > As for the two other types, I agree that we should have new events for > those. Maybe extend GstForceKeyUnit for the slice loss. But > ReferencePictureSelection probably requires a new custom event type. > > And don't feel too bad, I just re-implemented something that had existed > for like a year ;) > > And we should move the event to e.g. the video libarry to have it documented so that people find it :) https://bugzilla.gnome.org/show_bug.cgi?id=607742 Stefan |