Re: [gst-cvs] gst-plugins-base: interfaces: Use pow() instead of cbrt() for MSVC

[David S. <ds...@en...>]

On Thu, May 27, 2010 at 10:19:13PM +0200, Sebastian Dröge wrote:
> On Thu, 2010-05-27 at 12:56 -0700, David Schleef wrote:
> > Module: gst-plugins-base
> > Branch: master
> > Commit: 3edafbd0e5fa1f5b0d24e41fe52e44c201a763f0
> > URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=3edafbd0e5fa1f5b0d24e41fe52e44c201a763f0
> > 
> > Author: David Schleef <ds...@sc...>
> > Date:   Wed Dec  2 22:16:22 2009 -0800
> > 
> > interfaces: Use pow() instead of cbrt() for MSVC
> > 
> > ---
> > 
> >  gst-libs/gst/interfaces/streamvolume.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/gst-libs/gst/interfaces/streamvolume.c b/gst-libs/gst/interfaces/streamvolume.c
> > index a3efe46..e3d1d28 100644
> > --- a/gst-libs/gst/interfaces/streamvolume.c
> > +++ b/gst-libs/gst/interfaces/streamvolume.c
> > @@ -198,7 +198,7 @@ gst_stream_volume_convert_volume (GstStreamVolumeFormat from,
> >          case GST_STREAM_VOLUME_FORMAT_LINEAR:
> >            return val;
> >          case GST_STREAM_VOLUME_FORMAT_CUBIC:
> > -          return cbrt (val);
> > +          return pow (val, 1 / 3.0);
> >          case GST_STREAM_VOLUME_FORMAT_DB:
> >            return 20.0 * log10 (val);
> >        }
> 
> Hm, at the top of the file we have:
> 
> #ifndef HAVE_CBRT
> #define cbrt(x) (pow(abs(x),1.0/3.0))
> #endif
> 
> Why does your config.h define HAVE_CBRT?

This patch was leftover from a long time ago, and I simply noted that
cbrt() was not changed.  It did not occur to me that someone would
go through the trouble of detecting for cbrt() presence in order to
use it.

Also, your definition of cbrt() is wrong.



dave...