Re: [Gstreamer-openmax] [PATCH 1/3] A small fix for compile error with latest gstreamer

[Felipe C. <fel...@gm...>]

On Wed, Mar 24, 2010 at 12:14 AM, Clark, Rob <ro...@ti...> wrote:
>
> On Mar 23, 2010, at 5:04 PM, Felipe Contreras wrote:
>
>> On Tue, Mar 16, 2010 at 12:29 AM, Rob Clark <ro...@ti...> wrote:
>>> ---
>>>  omx/gstomx_base_filter.c |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> It's usually a good practice to copy-paste the actual error being fixed.
>>
>>> diff --git a/omx/gstomx_base_filter.c b/omx/gstomx_base_filter.c
>>> index 2d93f5c..7ebc52d 100644
>>> --- a/omx/gstomx_base_filter.c
>>> +++ b/omx/gstomx_base_filter.c
>>> @@ -716,7 +716,7 @@ out_flushing:
>>>
>>>         if (error_msg)
>>>         {
>>> -            GST_ELEMENT_ERROR (self, STREAM, FAILED, (NULL), (error_msg));
>>> +            GST_ELEMENT_ERROR (self, STREAM, FAILED, (NULL), ("%s", error_msg));
>>>             ret = GST_FLOW_ERROR;
>>>         }
>>>
>>> --
>>
>> I don't see how that could fail =/
>>
>
> sorry, could you paste below in the commit msg.. or would you rather I re-send the patch?

I'll append it. Thanks.

> -----------
> omx/gstomx_base_filter.c:763: warning: format not a string literal and no format arguments
> -----------
>
> the compiler expects first arg used in printf-like functions to be a string literal.

Ah, so it's a warning. I don't remember seeing it before, but ok. ACK.

-- 
Felipe Contreras