[gstreamer-bugs] [Bug 580869] dvdsubdec ARGB support

[GStreamer (bugzilla.gnome.org) <bug...@bu...>]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=580869

  GStreamer | gst-plugins-ugly | Ver: git

Jan Schmidt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |th...@ma...
 Attachment #134010|none                        |needs-work
               Flag|                            |




------- Comment #3 from Jan Schmidt  2009-05-15 10:49 UTC -------
In general this seems like an OK idea. A couple of notes on the patch:

* I'd prefer to use glib's CLAMP macro rather than the inline clip() function.
* Move the use_ARGB check out of the DRAW_RUN inner loop. Instead, I'd redefine
the Color_val struct to be guint A, Y_R, U_G, V_B and define separate palette
caches: palette_cache_rgb, hl_palette_cache_rgb. That way, you can switch to
select the different color palette outside the inner loop, and avoid the extra
check.

* Are you actually using dvdsubdec successfully somewhere? I stopped using it
in favour of gstdvdspu, so I'm not sure how complete its functionality is any
more.
* In the sinkpad setcaps function, the gst_pad_fixate_caps call looks wrong -
you want to check the entire set of allowed caps for ARGB support, not the
fixated set. Also, a bit further down - if the peer accepts the proposed caps,
you break from the loop without setting the use_ARGB flag. It looks like
use_ARGB will only get set if ARGB is in the set of allowed caps, but the peer
rejects it. At which point, it will set ARGB as the output caps, but not the
flag that actually renders in that mode.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=580869.