[gstreamer-bugs] [Bug 577436] New: xvimagesink should use xcontext->depth and not count bits in colorkey

[GStreamer (bugzilla.gnome.org) <bug...@bu...>]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=577436

  GStreamer | gst-plugins-base | Ver: git
           Summary: xvimagesink should use xcontext->depth and not count
                    bits in colorkey
           Product: GStreamer
           Version: git
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gst...@li...
        ReportedBy: en...@so...
         QAContact: gst...@li...
     GNOME version: Unspecified
   GNOME milestone: Unspecified


in gst_xvimagesink_get_xv_support() we currently count bits in
attribute.max_value to setup the colorkey for different screen-depths. The max
value is always a constant in the Xorg drivers. It will not reflect any
particular depth. Well, maybe it reflects the maximum depth supported by the
driver, and since practically all drivers support depth=24 the max value is the
same across all those drivers.

Below are some link to the source code of the Xorg drivers (since there is no
offical specification for this stuff AFAICS):

http://cgit.freedesktop.org/xorg/driver/xf86-video-ati/tree/src/radeon_video.c
http://cgit.freedesktop.org/xorg/driver/xf86-video-i740/tree/src/i740_video.c
http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/tree/src/i830_video.c
http://cgit.freedesktop.org/xorg/driver/xf86-video-mach64/tree/src/atimach64xv.c
http://cgit.freedesktop.org/xorg/driver/xf86-video-mga/tree/src/mga_video.c
http://cgit.freedesktop.org/xorg/driver/xf86-video-r128/tree/src/r128_video.c
http://cgit.freedesktop.org/xorg/driver/xf86-video-s3/tree/src/s3_video.c
http://cgit.freedesktop.org/xorg/driver/xf86-video-savage/tree/src/savage_video.c
http://cgit.freedesktop.org/xorg/driver/xf86-video-siliconmotion/tree/src/smi_video.c

Could people that have a xvideo driver where XV_COLORKEY is implemented (xvinfo
| grep XV_COLORKEY), try gst-plugins-base/tests/icles/test-colorkey, then apply
the patch and try again. Please report wheter it worked before and after and
attach the xvinfo output.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=577436.