[gstreamer-bugs] [Bug 363607] New: xvimagesink xwindow_draw_border() slowness

[GStreamer (bugzilla.gnome.org) <bug...@bu...>]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=3D363607

  GStreamer | gst-plugins-base | Ver: HEAD CVS

           Summary: xvimagesink xwindow_draw_border() slowness
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gst...@li...
        ReportedBy: en...@so...
         QAContact: gst...@li...
     GNOME version: Unspecified
   GNOME milestone: Unspecified


if one sets xvimagesink->keep_aspect=3DTRUE xvimagsink centers the pictur=
e in
gst_xvimagesink_xvimage_put(). A few lines down it calls
gst_xvimagesink_xwindow_draw_borders(). This is causing quite a slowdown =
in
performance for us (just commenting out the _xwindow_draw_borders() call =
make
it much better).

Now the plan is:
* first only call _xwindow_draw_borders() if xvimagesink->keep_aspect=3D=3D=
TRUE,
otherwise there will be no border anyway.
* next only do the centering and the border-drawing if the sizes have cha=
nged.

Finally I belive its up to the ui to paint the background black (or to wh=
at
ever). So wouldn't it make sense to have a 'draw-border' property (defaul=
t
TRUE), so that if apps handle the sizing, they can paint the border?


--=20
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=3Demail