From: GStreamer (bugzilla.gnome.org) <bug...@bu...> - 2006-10-08 12:42:15
|
Do not reply to this via email (we are currently unable to handle email responses and they get discarded). You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=3D359653 GStreamer | gstreamer (core) | Ver: HEAD CVS ------- Comment #10 from Mathieu Garcia 2006-10-08 12:41 UTC ------- Thank you for your comments. I've made some modifications according to yo= ur suggestions. #1 : "#define GST_CAT_DEFAULT GST_CAT_REGISTRY" was added in the C file #2 : Using pascal strings is a good idea but gcc doesn't recommend it, pl= ease see http://developer.apple.com/documentation/DeveloperTools/gcc-4.0.1/gcc/Pas= cal-Strings.html for further comments. So, as a workaround, I added a define "GST_BINARY_REGISTRY_SIZE_FACTOR" (set to 4 by default), to divide the le= ngths (GST_BINARY_REGISTRY_NAME_LEN, etc.). Some sanity check should be added i= n case we reach 0 byte length. So you can change this define to fit your needs. #3 : I'll check about gtk-doc #4 : Changed all calloc's to malloc's, as memory is always initialized. S= hould speed-up the process a little bit. #5 : Actually if we use a prepend operator, we'll corrupt the header, etc= . I didn't check much how to solve it but I'll do it soon. #6 : Fixed leaks + changed g_free's to gst_object_unref's Regarding the implementation of subclasses, I prefer to wait until we fin= d a solution that would fit everyone's needs. Any more opens ? --=20 Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=3Demail |