[gstreamer-bugs] [Bug 350761] [a52dec] Select output format based on peer element caps

[GStreamer (bugzilla.gnome.org) <bug...@bu...>]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=3D350761
 GStreamer | gst-plugins-ugly | Ver: HEAD CVS


Michael Smith changed:

           What    |Removed                     |Added
-------------------------------------------------------------------------=
---
                 CC|                            |ms...@fl...




------- Comment #3 from Michael Smith  2006-08-11 11:01 UTC -------
This patch doesn't look sufficient to me.

It adds:
 - a way to explicitly specify the downmix mode (which is fine, but
applications aren't going to use that; they'll just use playbin, etc.)
 - checking to see if the peer pad has a fixed number of channels set.

You need to do full caps negotiation instead, so that this _automatically=
_
works through audioconvert.

This used to be impossible - audioconvert would always choose to do the
conversion (I implemented this in fluendo's ac3 decoder, and it didn't wo=
rk).

However, after I rewrote audioconvert's caps negotiation to advertise tha=
t it
prefers certain formats above others (it prefers to NOT do channel downmi=
xing,
for instance), it should be possible to do this properly.

The caps-nego stuff is pretty complex, though, so I'd expect that to be a=
 bit
of  a pain. Some time when I have a chance (i.e. NOT in the next week), I=
'll
probably try implementing this in fluac3dec again. If that works, I'll se=
e if I
can provide a patch for a52dec too.


--=20
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=3Demail
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.