From: <tp...@ke...> - 2007-08-11 12:40:15
|
CVS Root: /cvs/gstreamer Module: gst-plugins-base Changes by: tpm Date: Sat Aug 11 2007 12:40:05 UTC Log message: * docs/libs/gst-plugins-base-libs-sections.txt: * gst-libs/gst/rtp/gstbasertpdepayload.c: * gst-libs/gst/rtp/gstbasertpdepayload.h: Mark as deprecated some macros which were presumably meant to be private API and accidentally exposed in the public header file. Also actually _init() lock (only works at the moment because the struct is zeroed out when created and the initial values in the mutex struct are zeroes too). (#459585) Modified files: . : ChangeLog docs/libs : gst-plugins-base-libs-sections.txt gst-libs/gst/rtp: gstbasertpdepayload.c gstbasertpdepayload.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-base/ChangeLog.diff?r1=1.3451&r2=1.3452 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-base/docs/libs/gst-plugins-base-libs-sections.txt.diff?r1=1.40&r2=1.41 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-base/gst-libs/gst/rtp/gstbasertpdepayload.c.diff?r1=1.46&r2=1.47 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-base/gst-libs/gst/rtp/gstbasertpdepayload.h.diff?r1=1.18&r2=1.19 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gst-plugins-base/ChangeLog,v retrieving revision 1.3451 retrieving revision 1.3452 diff -u -d -r1.3451 -r1.3452 --- ChangeLog 10 Aug 2007 17:35:51 -0000 1.3451 +++ ChangeLog 11 Aug 2007 12:39:50 -0000 1.3452 @@ -1,3 +1,14 @@ +2007-08-11 Tim-Philipp Müller <tim at centricular dot net> + + * docs/libs/gst-plugins-base-libs-sections.txt: + * gst-libs/gst/rtp/gstbasertpdepayload.c: + * gst-libs/gst/rtp/gstbasertpdepayload.h: + Mark as deprecated some macros which were presumably meant to be + private API and accidentally exposed in the public header file. + Also actually _init() lock (only works at the moment because the + struct is zeroed out when created and the initial values in the + mutex struct are zeroes too). (#459585) 2007-08-10 Stefan Kost <en...@us...> * docs/libs/Makefile.am: Index: gst-plugins-base-libs-sections.txt RCS file: /cvs/gstreamer/gst-plugins-base/docs/libs/gst-plugins-base-libs-sections.txt,v retrieving revision 1.40 retrieving revision 1.41 diff -u -d -r1.40 -r1.41 --- gst-plugins-base-libs-sections.txt 26 Jul 2007 14:33:01 -0000 1.40 +++ gst-plugins-base-libs-sections.txt 11 Aug 2007 12:39:51 -0000 1.41 @@ -796,6 +796,12 @@ GST_IS_BASE_RTP_DEPAYLOAD GST_IS_BASE_RTP_DEPAYLOAD_CLASS gst_base_rtp_depayload_get_type +<SUBSECTION Private> +QUEUE_LOCK_INIT +QUEUE_LOCK_FREE +QUEUE_LOCK +QUEUE_UNLOCK </SECTION> <SECTION> Index: gstbasertpdepayload.c RCS file: /cvs/gstreamer/gst-plugins-base/gst-libs/gst/rtp/gstbasertpdepayload.c,v retrieving revision 1.46 retrieving revision 1.47 diff -u -d -r1.46 -r1.47 --- gstbasertpdepayload.c 7 Jun 2007 21:08:38 -0000 1.46 +++ gstbasertpdepayload.c 11 Aug 2007 12:39:51 -0000 1.47 @@ -31,6 +31,15 @@ #include "gstbasertpdepayload.h" +#ifdef GST_DISABLE_DEPRECATED +#define QUEUE_LOCK_INIT(base) (g_static_rec_mutex_init(&base->queuelock)) +#define QUEUE_LOCK_FREE(base) (g_static_rec_mutex_free(&base->queuelock)) +#define QUEUE_LOCK(base) (g_static_rec_mutex_lock(&base->queuelock)) +#define QUEUE_UNLOCK(base) (g_static_rec_mutex_unlock(&base->queuelock)) +#else +/* otherwise it's already been defined in the header (FIXME 0.11)*/ +#endif GST_DEBUG_CATEGORY_STATIC (basertpdepayload_debug); #define GST_CAT_DEFAULT (basertpdepayload_debug) @@ -62,7 +71,7 @@ enum { PROP_0, - PROP_QUEUE_DELAY, + PROP_QUEUE_DELAY }; static void gst_base_rtp_depayload_finalize (GObject * object); @@ -617,6 +626,7 @@ /* only launch the thread if processing is needed */ if (filter->queue_delay) { GST_DEBUG_OBJECT (filter, "Starting queue release thread"); + QUEUE_LOCK_INIT (filter); filter->thread_running = TRUE; filter->thread = g_thread_create ((GThreadFunc) gst_base_rtp_depayload_thread, filter, Index: gstbasertpdepayload.h RCS file: /cvs/gstreamer/gst-plugins-base/gst-libs/gst/rtp/gstbasertpdepayload.h,v retrieving revision 1.18 retrieving revision 1.19 diff -u -d -r1.18 -r1.19 --- gstbasertpdepayload.h 29 Mar 2007 16:23:53 -0000 1.18 +++ gstbasertpdepayload.h 11 Aug 2007 12:39:51 -0000 1.19 @@ -25,7 +25,6 @@ G_BEGIN_DECLS -/* #define's don't like whitespacey bits */ #define GST_TYPE_BASE_RTP_DEPAYLOAD (gst_base_rtp_depayload_get_type()) #define GST_BASE_RTP_DEPAYLOAD(obj) \ (G_TYPE_CHECK_INSTANCE_CAST((obj),GST_TYPE_BASE_RTP_DEPAYLOAD,GstBaseRTPDepayload)) @@ -41,10 +40,14 @@ #define GST_BASE_RTP_DEPAYLOAD_SINKPAD(depayload) (GST_BASE_RTP_DEPAYLOAD (depayload)->sinkpad) #define GST_BASE_RTP_DEPAYLOAD_SRCPAD(depayload) (GST_BASE_RTP_DEPAYLOAD (depayload)->srcpad) +#ifndef GST_DISABLE_DEPRECATED +/* this was presumably never meant to be public API, or should at least + * have been prefixed if it was. Don't use. (FIXME: remove in 0.11) */ #define QUEUE_LOCK_INIT(base) (g_static_rec_mutex_init(&base->queuelock)) #define QUEUE_LOCK_FREE(base) (g_static_rec_mutex_free(&base->queuelock)) -#define QUEUE_LOCK(base) (g_static_rec_mutex_lock(&base->queuelock)) -#define QUEUE_UNLOCK(base) (g_static_rec_mutex_unlock(&base->queuelock)) typedef struct _GstBaseRTPDepayload GstBaseRTPDepayload; typedef struct _GstBaseRTPDepayloadClass GstBaseRTPDepayloadClass; |