From: <bug...@bu...> - 2005-01-24 10:58:10
|
Please DO NOT reply to this by email. All additional comments should be made in the comments box of this bug report. http://bugzilla.gnome.org/show_bug.cgi?id=164856 GStreamer | gst-plugins | Ver: HEAD CVS ------- Additional Comments From Maciej Katafiasz 2005-01-24 05:58 ------- Reviewed the patch. Seems to work as per very basic testing I gave it. Code looks OK, but I have 2 slight issues: 1) why are you sending DISCONT in first run of chain() after element is created? I don't see much sense here, there's no stream to DISCONT yet as it is very first run after creation 2) Please s/#ifdef __cplusplus/G_BEGIN_DECLS/ Marking as needwork, but the above are very minor issues, will commit after they are resolved. ------- You are receiving this mail because: ------- You are the assignee for the bug. You are the QA contact for the bug. |