Re: [gst-devel] Re: [gst-cvs] company gstreamer: gstreamer/ gstreamer/gst/

[Benjamin O. <in...@pu...>]

On Mon, 26 Jan 2004, Thomas Vander Stichele wrote:

> The only thing I mind is people touching the stuff I'm working on
> without realizing what's going on when I explicitly ask for feedback.
> If you ask me about it I'll explain without fail.  But don't "fix" it
> without taking the time to look into it.  I try to do the same, and feel
> free to set me in my place when I don't.
>
I hate it when there's half finished code somewhere in the core.
Please do it right in one way, but don't leave it feeling half finished.
And if you must leve it half finished, please add a comment on why you did
it.

Benjamin

PS: While looking at gsterror.c more closely there's some more issues:
- "No standard error message for domain %s and code %d" should be a
g_warning at least.
- gst_error_get_message should check the code before doing
gst_core_errors[code] - accessing arrays without bounds checking and such.