Re: [gst-devel] Re: [gst-cvs] wingo gstreamer: gstreamer/gst/elements/

[Andy W. <wi...@po...>]

Hi Ronald,

On Tue, 30 Sep 2003, Ronald Bultje wrote:

> On Tue, 2003-09-30 at 15:11, Andy Wingo wrote:
> > make filesink handle events only in the chainfunction
> [..]
> > -/* supported events */
> > -static const GstEventMask *
> > -gst_filesink_get_event_mask (GstPad *pad)
[...]
> I totally don't like this. I know someone added a g_return_val_if_fail()
> for event functions on sink pads, but I think we shouldn't do that for
> event_mask functions. How else am I supposed to query whether the sink
> pad supports seeking or not?

Hm, sorry. I can't revert it right now, my laptop is at home. I was just getting
rid of the warning when setting the event function. My bad! You can revert this
if you like, cause it will take a few days for my laptop to hit the net again.

If you want to document this behavior too, that would be grand -- i.e. don't set
event functions on sink pads (handle instead in chain functions) but you can set
event masks to advertise what events you support, etc...

wingo