From: <bug...@wi...> - 2003-10-07 10:11:38
|
Please do not reply to this email- if you want to comment on the bug, go to the URL shown below and enter your comments there. http://bugzilla.gnome.org/show_bug.cgi?id=123946 Changed by rb...@ro.... --- shadow/123946 Mon Oct 6 08:14:56 2003 +++ shadow/123946.tmp.27741 Tue Oct 7 06:10:45 2003 @@ -10,13 +10,13 @@ Component: gst-plugins AssignedTo: gst...@bu... ReportedBy: rb...@ro... QAContact: gst...@bu... TargetMilestone: 0.6.4 URL: -Summary: mpeg2dec-0.3.2 run failure +Summary: [PATCH] mpeg2dec-0.3.2 run failure Fix attached. Works for me. Please test. ------- Additional Comments From rb...@ro... 2003-10-06 08:04 ------- Created an attachment (id=20496) give it a go @@ -36,6 +36,13 @@ STATE_BUFFER (which is 0 in 0.3.2 and -1 in 0.3.1...) and make them check for both STATE_BUFFER and -1 and then define STATE_BUFFER as 0, as it is in 0.3.2. I personally consider this pretty ugly, but it's a way of fixing it... Opinions? + +------- Additional Comments From rb...@ro... 2003-10-07 06:10 ------- +I've implemented checking for both STATE_BUFFER (0) and -1 in CVS, so +that binaries of this plugin will work with both libmpeg2-0.3.1 and +-0.3.2. Patch is same as above, but with STATE_BUFFER defined as 0 +instead of -1, and the two checks in the code where it checks for +state being STATE_BUFFER need an additional check for state == -1. |