#431 Tests fail with ImageMagick 7.1.1-33

[Petr Písař]

ImageMagick 7.1.1-33 deprecated "convert" and warns on it. These warnings breaks tests which expect no warnings.

The attached patch changes code and tests to execute "magick" command instead for "convert" and adapts options to the stricter magick command.

Ideal fix would preserve compatibility with ImageMagick version 6 (executing "convert" there), but the code is missing a required infrastructure. Unfortunately I have no place to test it because all supported Fedora versions have already moved to ImageMagick version 7.

[Petr Písař]

That patch was based on fix from https://sourceforge.net/p/gscan2pdf/bugs/427/. 0001-Execute-magick-instead-of-convert-command.patch is patch for vanilla gscan2pdf.

[Chris Mayo]

I'm skipping a lot of tests so the only one I'm seeing fail is3722_user_defined.t , I fixed that with:

--- a/t/3722_user_defined.t
+++ b/t/3722_user_defined.t
@@ -38,7 +38,7 @@ $slist->import_files(
             },
             error_callback => sub {
                 my ( $uuid, $process, $msg ) = @_;

-                is( $msg, 'error',
+                is( substr($msg, 0, 5), 'error',
                     'user_defined caught error injected in queue' );
             },
         );

https://sourceforge.net/p/gscan2pdf/code/merge-requests/39/

[Petr Písař]

This issue was resolved in gscan2pdf-2.13.5.