Menu

#404 t/351_unpaper.t fails with ffmpeg-5.1

v1.0_(example)
closed-accepted
nobody
None
5
2022-09-18
2022-08-31
No

After upgrading ffmpeg from 5.0.1 to 5.1, t/351_unpaper.t started
failing:

$ xvfb-run -d /usr/bin/perl -Ilib t/351_unpaper.t
1..7
ok 1 - Resolution of imported image
2022/08/31 12:30:01 [image2 @ 0x5608901ecbc0] Encoder did not produce proper pts, making some up.
[image2 @ 0x5608901ecbc0] The specified filename '/tmp/DSK7RSEpdU/1RTuwFulfv.pnm' does not contain an image sequence pattern or a pattern is invalid.
[image2 @ 0x5608901ecbc0] Use a pattern such as %03d for an image sequence or use the -update option (with -frames:v 1 if needed) to write a single image.
not ok 2 - no warnings
#   Failed test 'no warnings'
#   at t/351_unpaper.t line 91.
not ok 3 - no warnings
#   Failed test 'no warnings'
#   at t/351_unpaper.t line 91.
ok 4 - Resolution of processed image
/tmp/DSK7RSEpdU/86_uDLL4ZK.pnm PBM 2104x2974 2104x2974+0+0 1-bit Bilevel Gray 782175B 0.010u 0:00.007
ok 5 - valid image created
ok 6 - using session directory
Your system does not have Image::PNG::Libpng installed, so some
PNG functions may not run correctly.
ok 7 - PDF is A4
ok 8 - cmdline v0.3
ok 9 - cmdline v0.4
# Looks like you planned 7 tests but ran 9.
# Looks like you failed 2 tests of 9 run.

This is due to a new warning in ffmpeg and unpaper needs to adapt
https://github.com/unpaper/unpaper/issues/113.

An attached patch adapts the test to ignore the new warnings.

1 Attachments

Discussion

  • Jeffrey Ratcliffe

    Thanks for the patch. I'm away from my main development machine for another week. I'll take a more detailed look next week.

     
  • Jeffrey Ratcliffe

    Committed and pushed. Thanks again.

     
  • Jeffrey Ratcliffe

    • status: open --> closed-accepted
     

Log in to post a comment.