Menu

#335 Tests fail with sane-backends 1.0.28

v1.0_(example)
closed-fixed
nobody
None
5
2019-11-27
2019-11-26
No

After upgading sane-backends from 1.0.27 to 1.0.28 two tests fail:

$ xvfb-run -d perl -Ilib t/0624_Dialog_Scan_CLI.t 
1..5
ok 1 - use Gscan2pdf::Dialog::Scan::CLI;
ok 2 - Created dialog
ok 3 - An object of class 'Gscan2pdf::Dialog::Scan::CLI' isa 'Gscan2pdf::Dialog::Scan::CLI'
not ok 4 - error-free scan despite illegal option
#   Failed test 'error-free scan despite illegal option'
#   at t/0624_Dialog_Scan_CLI.t line 100.
# Looks like you planned 5 tests but ran 4.
# Looks like you failed 1 test of 4 run.

$ xvfb-run -d perl -Ilib t/081_Frontend_CLI.t             1..48
[...]
ok 43 - scanimage starts
not ok 44 - error callback called: Unknown message: Output format is not set, using pnm as a default.
#   Failed test 'error callback called: Unknown message: Output format is not set, using pnm as a default.'
#   at t/081_Frontend_CLI.t line 381.
ok 45 - scanimage scans

I believe this the same issue as reported in https://rt.cpan.org/Ticket/Display.html?id=130933.

Discussion

  • Jeffrey Ratcliffe

    Does the attached patch fix things?

     
  • Jeffrey Ratcliffe

    That makes another test fail. Try this.

     
    • Petr Písař

      Petr Písař - 2019-11-27

      It works me. I tested it on gscan2pdf-2.5.6 because git master needs new dependencies.

       
  • Jeffrey Ratcliffe

    Thanks for the confirmation.

     
  • Jeffrey Ratcliffe

    • status: open --> closed-fixed
     

Log in to post a comment.