Grip / Patches / #151 Fix for 3105576 Improper handling of CDROM_AUDIO

#151 Fix for 3105576 Improper handling of CDROM_AUDIO_INVALID

Milestone: None

Status: closed-fixed

Owner: nobody

Labels: None

Priority: 5

Updated: 2017-04-20

Created: 2010-11-08

Creator: Tom Kelly

Private: No

When using the CDROMSUBCHNL ioctl, the code does not handle the CDROM_AUDIO_INVALID audiostatus vlaue. As a result, it thinks the disc is playing, and so you cannot select any other track than the current track.

Patch is attached

Discussion

Tom Kelly - 2010-11-08

patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Solbu - 2017-04-16

status: open --> closed-out-of-date

Group: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Solbu - 2017-04-16

Patch is malformed.

git apply --check ../patches/2017-04-16/grip-3.3.1-Improper-handling-of-CDROM_AUDIO_INVALID.patch
fatal: unrecognized input

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Solbu - 2017-04-20

status: closed-out-of-date --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Solbu - 2017-04-20

By reading the patch manually, I eventually figured out where to put the new lines. The fix will be included in the next release.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fix for 3105576 Improper handling of CDROM_AUDIO_INVALID

Group

Searches

Help

#151 Fix for 3105576 Improper handling of CDROM_AUDIO_INVALID

Discussion