#329 versionbuf buffer overflow in 'ja' locale

[Anonymous]

Grip 3.3.1 crashed due to buffer overflow in 'ja' locale.

In the function MakeAboutPage() of grip.c, versionbuf declared

char versionbuf[20];

and used as follows.

sprintf(versionbuf,_("Version %s"),VERSION);
label=gtk_label_new(versionbuf);

When using po/ja.po, this string needs 22bytes length.
And this causes buffer overflow.

Please increase the size of versionbuf and check the size with g_snprinf().
Or use g_strdup_printf() to avoid this.

[Solbu]

We believe it was fixed in version 3.3.2 by applying an old Debian patch from 2006.