RE: [Grinder-development] Problem with "expires" value in Cookie and suggested patch

[Philip A. <pa...@be...>]

Thanks. In next beta.

- Phil=20

 > -----Original Message-----
 > From: gri...@li...=20
 > [mailto:gri...@li...] On=20
 > Behalf Of Martin Wagner
 > Sent: 12 December 2005 10:51
 > To: gri...@li...
 > Subject: Re: [Grinder-development] Problem with "expires"=20
 > value in Cookie and suggested patch
 >=20
 > Hi Phil,
 >=20
 > sorry for not getting back on you this long... Your patch=20
 > works for our weird=20
 > Cookies, thanks a lot!
 >=20
 > Martin
 >=20
 > Am Freitag, 25. November 2005 21:03 schrieb Philip Aston:
 > > Hi Martin,
 > >
 > > Can you try this simpler patch.
 > >
 > > (I haven't tested it, so it may well be broken).
 > >
 > > Thanks,
 > >
 > > - Phil
 > >
 > >
 > > Index: Cookie.java
 > > =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 > > RCS file: /work/cvs/src/grinder/src/HTTPClient/Cookie.java,v
 > > retrieving revision 1.4
 > > diff -u -r1.4 Cookie.java
 > > --- Cookie.java	21 Mar 2005 19:28:16 -0000	1.4
 > > +++ Cookie.java	25 Nov 2005 08:13:31 -0000
 > > @@ -269,6 +269,20 @@
 > >  		    pos =3D Util.skipSpace(buf, pos);
 > >  		    if (pos < len  &&  buf[pos] =3D=3D ','  &&  pos > beg)
 > >  			beg =3D pos+1;
 > > +
 > > +               // Some other twits put a comma after the date.
 > > +               // Replace it with a space.
 > > +               pos =3D Util.skipSpace(buf, beg);
 > > +
 > > +               // Skip past the date.
 > > +               while (pos < len &&
 > > +                      (Character.isDigit(buf[pos]) ||=20
 > buf[pos] =3D=3D '-'))
 > > {
 > > +                 ++pos;
 > > +               }
 > > +
 > > +               if (pos < len && buf[pos] =3D=3D ',') {
 > > +                 buf[pos] =3D ' ';
 > > +               }
 > >  		}
 > >
 > >  		comma =3D set_cookie.indexOf(',', beg);
 > >
 > >  > -----Original Message-----
 > >  > From: Philip Aston
 > >  > Sent: 21 November 2005 15:35
 > >  > To: Martin Wagner
 > >  > Cc: gri...@li...
 > >  > Subject: RE: [Grinder-development] Problem with "expires"
 > >  > value in Cookie and suggested patch
 > >  >
 > >  > OK. Relaxed is good, so will change anyway.
 > >  >
 > >  > - Phil
 > >  >
 > >  >
 > >  > -----Original Message-----
 > >  > From:	Martin Wagner [mailto:mar...@tn...]
 > >  > Sent:	Mon 21/11/2005 14:24
 > >  > To:	Philip Aston
 > >  > Cc:	gri...@li...
 > >  > Subject:	Re: [Grinder-development] Problem with
 > >  > "expires" value in Cookie and suggested patch
 > >  > -----BEGIN PGP SIGNED MESSAGE-----
 > >  > Hash: SHA1
 > >  >
 > >  > Phil,
 > >  >
 > >  > actually, it's not a web server's fault, the strange=20
 > header is from a
 > >  > custom PHP application that we unfortunately cannot change.
 > >  > However, at
 > >  > least firefox seems to accept it (Opera and Konqueror
 > >  > obviously ignore
 > >  > the expires flag, and I couldn't check with IE), so probably
 > >  > it's a good
 > >  > idea to output a warning but not an exception if such a=20
 > second comma
 > >  > situation happens...
 > >  >
 > >  > Thanks,
 > >  > Martin
 > >  >
 > >  > Philip Aston wrote:
 > >  > > Thanks Martin,
 > >  > >
 > >  > > I will apply this, or something close to it.
 > >  > >
 > >  > > Can you tell me what the web server is for the change log?
 > >  > >
 > >  > > Thanks,
 > >  > >
 > >  > > - Phil
 > >  > >
 > >  > > -----Original Message-----
 > >  > > From:	gri...@li...
 > >  >
 > >  > on behalf of Martin Wagner
 > >  >
 > >  > > Sent:	Sun 20/11/2005 22:51
 > >  > > To:	gri...@li...
 > >  > > Cc:
 > >  > > Subject:	[Grinder-development] Problem with "expires"
 > >  >
 > >  > value in Cookie and suggested patch
 > >  >
 > >  > > Hello,
 > >  > >
 > >  > > I started working with the Grinder3 recently and stumbled
 > >  >
 > >  > over a problem
 > >  >
 > >  > > with non-standard-compliant cookies. In our case, we
 > >  >
 > >  > receive a cookie
 > >  >
 > >  > > header of the following kind:
 > >  > >
 > >  > > suid2=3Dd1.3471+9e89c2e5ec898f2381a0d3c825d2b4dd; path=3D/;
 > >  > > domain=3D.barfoo.com; expires=3DFriday, 01-01-2038, 00:00:00 =
GMT
 > >  > >
 > >  > > The web server puts an additional comma after the date and
 > >  >
 > >  > before the
 > >  >
 > >  > > time. The attached fix should remedy this problem, perhaps
 > >  >
 > >  > you might
 > >  >
 > >  > > find it useful.
 > >  > >
 > >  > > Cheers,
 > >  > > Martin
 > >  >
 > >  > - --
 > >  > Dr. Martin Wagner
 > >  > TNG Technology Consulting GmbH
 > >  > -----BEGIN PGP SIGNATURE-----
 > >  > Version: GnuPG v1.4.2 (GNU/Linux)
 > >  > Comment: Using GnuPG with Thunderbird -=20
 > http://enigmail.mozdev.org
 > >  >
 > >  > iD8DBQFDgdiDKc7ZRA1q1CcRAin/AKD072xRX2UD72TkncbsxU33oTRRiwCcCkhP
 > >  > Ol1dsKW7yUjwKYhAn4mD+5U=3D
 > >  > =3DBRnz
 > >  > -----END PGP SIGNATURE-----
 > >
 > > -------------------------------------------------------
 > > This SF.net email is sponsored by: Splunk Inc. Do you grep=20
 > through log
 > > files for problems?  Stop!  Download the new AJAX search=20
 > engine that makes
 > > searching your log files as easy as surfing the  web. =20
 > DOWNLOAD SPLUNK!
 > > http://ads.osdn.com/?ad_idv37&alloc_id=16865&op=3DClick
 > > _______________________________________________
 > > Grinder-development mailing list
 > > Gri...@li...
 > > https://lists.sourceforge.net/lists/listinfo/grinder-development
 >=20
 > --=20
 > Dr. Martin Wagner
 > TNG Technology Consulting GmbH
 > E-Mail: mar...@tn...
 > Mobile: +49 (1 76) 23 94 74 29
 > Phone: +49 (89) 21 58 99 60
 >=20