#505 I get the "without backups" warning even when the "Create backup files" checkbox is checked.

[Stefan Monov]

The "are you sure you want to replace blahblah with an empty string without creating backups" msgbox shows when I press "Replace", even if "Create backup files" is enabled.
I've attached a screenshot showing the exact setup (incl. query string, etc) with which I had the problem.

[Stefan Monov]

I just tried answering "yes" to the warning and verified that backup files were created. So the problem is only in the text of the message.

[Stefan Kueng]

That's expected: if the replace string is empty, the warning shows up independently of the "create backup" checkbox. That's to prevent accidental clicks on "replace" instead of "search".
Also see issue [#440] and [#217].

[Stefan Monov]

Fair enough, I'm not saying that the msgbox should go away. But it'd be good to have the text differ between the "empty replacement string, but backups enabled" and "backups disabled altogether" cases. In the first case it shouldn't include the text "... without creating backups" IMO.