Re: [GM-core] Mogrify -preserve implementation

[Bob F. <bfr...@si...>]

On Tue, 23 Feb 2016, Niko Rosvall wrote:

> Hi,
>
> I wrote a fairly naive implementation to keep file timestamps when
> running mogrify. I added an option -preserve to the command mogrify.
>
> By no means it's not perfect as it does not care about Windows. I hardly
> use Windows at all, so it fairly hard for me to implement support for
> it. However, I'm willing to do it, if this is a feature that GM wants to
> include.

Few of us love Windows, but we are dedicated to making sure that 
GraphicsMagick Windows users are well supported within the 
capabilities of the operating system.

> Some questions: Would it be better to implement the actual code into
> separate files (now it's just all in magick/command.c). Maybe
> magic/preserve.c?

What is currently typically done is to put Unix-specific code in 
magick/unix_port.c and Windows-specific code in magick/nt_base.c. 
Similar functions added to each place can allow a common 
implementation in magick/command.c to work.

The magick/studio.h header provides a MagickFstat() macro which 
provides porting definitions.  Windows does provide fstat as well as a 
a _fstati64() function (for large files).  I am not sure how one sets 
file timestamps under Windows.

Bob
-- 
Bob Friesenhahn
bfr...@si..., http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/