#613 static module loader is still case-sensitive

[xm]

You have already tried to fix that in this commit (fix for Debian bug 911386):
https://sourceforge.net/p/graphicsmagick/code/ci/1950b22122dff2e6b383bcc8c65b7d3932d77ba2/

but the problem is still there, as you are comparing the original string and not the "upperized" one, relevant line in static.c OpenModule():

(memcmp(ModuleAliases[index].magick,module,name_length) == 0))

should be

(memcmp(ModuleAliases[index].magick,module_name,name_length) == 0))

[xm]

I should add that this is the 1st memcmp in the /* Assign module name from alias. */ for-cycle.

If the OpenModule() input parameter module is e.g. "jpg", the module alias "JPEG" will not be copied into module_name and then the 2nd for-cycle cannot find the relevant static module...

[Bob Friesenhahn]

On Wed, 18 Sep 2019, xm wrote:

I should add that this is the 1st memcmp in the / Assign module name from alias. / for-cycle.

If the OpenModule() input parameter module is e.g. "jpg", the module alias "JPEG" will not be copied into module_name and then the 2nd for-cycle cannot find the relevant static module...

I think that this is fixed now in GraphicsMagick Mercurial. Please
double-check my work.

Thanks,

Bob

Bob Friesenhahn
bfriesen@simple.dallas.tx.us, http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer, http://www.GraphicsMagick.org/
Public Key, http://www.simplesystems.org/users/bfriesen/public-key.txt

[Bob Friesenhahn]

This should be fixed by changeset 16111:45d2f234c8a1. Thank you for the report!

[xm]

That was fast, thanks!
Now it is ok, I tested current snapshot.

[Bob Friesenhahn]

On Thu, 19 Sep 2019, xm wrote:

That was fast, thanks!
Now it is ok, I tested current snapshot.

Sorry for not fixing this issue correctly the first time. It must be
a classic case of haste makes waste. :-)

Bob

Bob Friesenhahn
bfriesen@simple.dallas.tx.us, http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer, http://www.GraphicsMagick.org/
Public Key, http://www.simplesystems.org/users/bfriesen/public-key.txt