Menu ▾ ▴

#526 heap-buffer-overflow in WriteOnePNGImage

v1.0_(example)
closed-fixed
Bob Friesenhahn
None
5
2018-07-04
2017-12-05
littleputa
No

ubuntu@ubuntu:~/fuzz_py$ gm convert -version
GraphicsMagick 1.4 snapshot-20171203 Q8

ubuntu@ubuntu:~/fuzz_py$ gm convert mng.png 1.mng

==3547==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6020000003b7 at pc 0x7fe4c9d235c3 bp 0x7ffc61f38b70 sp 0x7ffc61f38b68
READ of size 1 at 0x6020000003b7 thread T0
#0 0x7fe4c9d235c2 in WriteOnePNGImage /home/ubuntu/GraphicsMagick/coders/png.c:7061:26
#1 0x7fe4c9d0a121 in WriteMNGImage /home/ubuntu/GraphicsMagick/coders/png.c:9881:18
#2 0x7fe4c9a54319 in WriteImage /home/ubuntu/GraphicsMagick/magick/constitute.c:2230:14
#3 0x7fe4c9a54aa7 in WriteImages /home/ubuntu/GraphicsMagick/magick/constitute.c:2387:21
#4 0x7fe4c99e6d84 in ConvertImageCommand /home/ubuntu/GraphicsMagick/magick/command.c:6087:11
#5 0x7fe4c9a050db in MagickCommand /home/ubuntu/GraphicsMagick/magick/command.c:8872:17
#6 0x7fe4c9a23495 in GMCommandSingle /home/ubuntu/GraphicsMagick/magick/command.c:17393:10
#7 0x7fe4c9a22585 in GMCommand /home/ubuntu/GraphicsMagick/magick/command.c:17446:16
#8 0x7fe4c775af44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287
#9 0x41980b in _start (/usr/local/bin/gm+0x41980b)

0x6020000003b7 is located 2 bytes to the right of 5-byte region [0x6020000003b0,0x6020000003b5)
allocated by thread T0 here:
#0 0x4b95d7 in realloc (/usr/local/bin/gm+0x4b95d7)
#1 0x7fe4c9b2e85f in MagickRealloc /home/ubuntu/GraphicsMagick/magick/memory.c:473:18
#2 0x7fe4c9b5d85e in OpenCache /home/ubuntu/GraphicsMagick/magick/pixel_cache.c:3155:7
#3 0x7fe4c9b5c9e3 in ModifyCache /home/ubuntu/GraphicsMagick/magick/pixel_cache.c:2955:18
#4 0x7fe4c9b5f86c in SetCacheNexus /home/ubuntu/GraphicsMagick/magick/pixel_cache.c:3891:7
#5 0x7fe4c9b590b7 in GetCacheNexus /home/ubuntu/GraphicsMagick/magick/pixel_cache.c:2063:10
#6 0x7fe4c9b5962f in GetCacheViewPixels /home/ubuntu/GraphicsMagick/magick/pixel_cache.c:2181:10
#7 0x7fe4c9b5962f in GetImagePixels /home/ubuntu/GraphicsMagick/magick/pixel_cache.c:2353
#8 0x7fe4c9b71ad7 in GrayscalePseudoClassImage /home/ubuntu/GraphicsMagick/magick/quantize.c:1700:17
#9 0x7fe4c9b70a5c in QuantizeImage /home/ubuntu/GraphicsMagick/magick/quantize.c:2432:5
#10 0x7fe4c9af34b2 in SetImageType /home/ubuntu/GraphicsMagick/magick/image.c
#11 0x7fe4c9d03e32 in WriteMNGImage /home/ubuntu/GraphicsMagick/coders/png.c
#12 0x7fe4c9a54319 in WriteImage /home/ubuntu/GraphicsMagick/magick/constitute.c:2230:14
#13 0x7fe4c9a54aa7 in WriteImages /home/ubuntu/GraphicsMagick/magick/constitute.c:2387:21
#14 0x7fe4c99e6d84 in ConvertImageCommand /home/ubuntu/GraphicsMagick/magick/command.c:6087:11
#15 0x7fe4c9a050db in MagickCommand /home/ubuntu/GraphicsMagick/magick/command.c:8872:17
#16 0x7fe4c9a23495 in GMCommandSingle /home/ubuntu/GraphicsMagick/magick/command.c:17393:10
#17 0x7fe4c9a22585 in GMCommand /home/ubuntu/GraphicsMagick/magick/command.c:17446:16
#18 0x7fe4c775af44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287

SUMMARY: AddressSanitizer: heap-buffer-overflow /home/ubuntu/GraphicsMagick/coders/png.c:7061:26 in WriteOnePNGImage
Shadow bytes around the buggy address:
0x0c047fff8020: fa fa 00 04 fa fa 00 04 fa fa 00 04 fa fa 00 04
0x0c047fff8030: fa fa fd fd fa fa 00 04 fa fa fd fd fa fa fd fa
0x0c047fff8040: fa fa fd fa fa fa 00 fa fa fa 00 fa fa fa 06 fa
0x0c047fff8050: fa fa fd fa fa fa 02 fa fa fa 02 fa fa fa fd fa
0x0c047fff8060: fa fa fd fa fa fa fd fd fa fa 05 fa fa fa 00 04
=>0x0c047fff8070: fa fa fd fd fa fa[05]fa fa fa 04 fa fa fa 00 02
0x0c047fff8080: fa fa 00 02 fa fa fa fa fa fa fa fa fa fa fa fa
0x0c047fff8090: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c047fff80a0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c047fff80b0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c047fff80c0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
==3547==ABORTING

1 Attachments
mng.png

Discussion

  • littleputa

    littleputa - 2017-12-06

    credit: littleputa of nsfocus security team.

     

  • Bob Friesenhahn

    Bob Friesenhahn - 2017-12-07
    • status: open --> closed-fixed
    • private: Yes --> No
     

  • Bob Friesenhahn

    Bob Friesenhahn - 2017-12-07

    This issue is fixed by Mercurial changeset 15291:5b8414c0d0c4. Since this is a very small read over-run of a heap buffer, and because usually the underlying allocation size is larger than what was requested, this problem should usually be benign.

    Thank you for reporting this problem.

     

  • littleputa

    littleputa - 2018-07-04

    CVE-2017-17501 credit: littleputa of nsfocus security team.

     

    Last edit: littleputa 2018-07-04

Log in to post a comment.