NPE in SearchNames
Brought to you by:
james22
Menu
▾
▴
Doesn't seem to happen to me. Perhaps it's line 2154 in current git you mean:
//#if polish.android
-> gsl.ele[GuiSearchLayout.TEXT].setText(sb.toString());
//#else
setTitle(sb.toString());
//#endif
I put if (gsl != null) around it, but to asses impact for release - Does it show to the user somehow? How?
If so, is it always or once in a while?
I saw this on the Galaxy Mini. Is announced to user as alert, doesn't seem to stop search from working.
Seems to be fixed.
Yes, it was line 2154 and yes, it was announced as an alert, which did not stop search from working. On the other hand, it was a bit confusing. Haven't tried the fix yet, but seems to solve the issue. Another approach to solve this issue might be to initialise gsl property in class constructor.
I don't want to open a new ticket at the moment, so I ask here, since the question is relating to searching. How is the new searching with a native keyboard supposed to work? It seems, that it doesn't work for me on HTC Dream (aka T-Mobile G1) as expected. Or shall I rather open a new ticket for this?
It's supposed to work so that the native keyboard is opened, and when I type letters or numbers on the native keyboard, they are handled just like they would be if written on a hardware keyboard.
Works that way for me. If it doesn't work that way for you, please open a new ticket.
However, I now see that if split screen is on, the behaviour described above is not expected, as the split-screen mode still directs keyboard input to the map viewer, not to search. (no multiplexer / input chooser in the "windowing system" yet). Probably should add a condition to not open the native keyboard in split screen mode until / unless a keyboard multiplexer is there.
OK, search with native keyboart works, but only sometimes. I have not found the principle when it works and when it doesn't yet. But when I find out some more info, I'll open a new ticket. But there is definitely one problem - I have no visual feedback of letters I type. I think that they should show up in top most line of search results screen, but they do not. Sometimes they appeared in "search inputfield", but I had to tap the screen to make it visible. Sometimes the inputfield was empty even after I had typed some letters. I suspect that this is the case when search does not work.
"I think that they should show up in top most line of search results screen, but they do not."
Yes, works work me, never had a problem. (Well "never" is the few days the feature has been there, but anyway :-)
Hmm, actually that's not true, at first I also had issues with the "title line" not showing on Android, but then the implementation was different (not sure if I even committed this code).
Maybe it would be useful if you test your hypothesis of the issue being GuiSearchLayout not inited by seeing if it helps to init gsl an GuiSearch constructor like you suggested.