Re: [Gpsbabel-code] garmin.c

[<0x...@qu...>]

Hi again,

here's a new patch following your hint. It now uses valid_waypt_chars. It works for etrex Legend HCx and I assume it does for Vista HCx. Other models are not affedted.

Cheers,
Gunnar

Robert Lipe writes:
 > On Tue, Sep 2, 2008 at 4:48 PM, <0x...@qu...> wrote:
 > 
 > > Hi!
 > >
 > > I noticed that garmin.c forces a "militant" charset on names of route
 > > points. A comment in the code states that's accoring to the garmin spec. At
 > > least the etrex Legend HCx, however, accepts the regular charset for route
 > > points. So I patched it back not to be so strict.
 > >
 > 
 > ...and broke units that are strict.
 > 
 > Please consider modifying the swtich on gps_save_id that handles that model
 > to set valid_waypt_chars to what you know are OK and making that loop test
 > against valid_waypt_charas instead of MILITANT_VALID_WAYPT_CHARS.   THat
 > allows us to be very surgical in what's allowed.
 > 
 > 
 > 
 > 
 > > A second fix corrects bounds on comment lengt for route point. It's more
 > > for looks though, as both sizeof(GPS_PWay->.cmnt) and
 > > sizeof(GPS_PWay->ident) are 256.
 > 
 > 
 > Applied.   Thanx.
-- 
GMX startet ShortView.de. Hier findest Du Leute mit Deinen Interessen!
Jetzt dabei sein: http://www.shortview.de/wasistshortview.php?mc=sv_ext_mf@gmx