Re: [Gpsbabel-code] [PATCH] Humminbird .hwr format support, and projection Q.

[Robert L. <rob...@gp...>]

On Thu, Aug 14, 2008 at 4:00 PM, Björn Augustsson <og...@gm...> wrote:

> On Thu, Aug 14, 2008 at 9:19 AM, Olaf Klein <o.b...@pr...>
> wrote:
>
> Attached is a patch that adds:
>
> * Write support.
> * Icon support (read and write).
>

Thanx.  Applied.  I cleaned up a few warnings and fixed a bug you probably
didn't yet know you had.

gpsbabel -i csv -f whatever -o humminbird -f one -o humminbird -f two

would have bad waypoint numbers in file "two".  I fixed that before commit.
Please update and be sure I didn't break something else.



> With this patch, doing
>
> gpsbabel -i humminbird -f $i  -o humminbird -F ${i}.out && diff $i ${i}.out
>
> returns nothing (ie the files are equal) for all three .hwr files I have.
> [ ... ]
> /August. Still no tests though.
>


That pretty is the test.  If you look in testo and replace 'diff' with
'compare' (a glorified wrapper for diff that tries to handle binary/text in
a sensible way) and provide sample files,   you're about 90% there.

Ideally, you'd test reading and writing individually so that self-cancelling
errors get caught but I'd rather have a weak test than none at all.   Given
how many OSes/CPUs/compilers/library combinations we support, it's a big
help to us as it also lets us do things like use valgrind and our leak tests
and such.

Thanx,
RJL