Satellite Nickname Not escaped for PANGO
Real time satellite tracking and orbit prediction
Status: Beta
Brought to you by:
csete
Menu
▾
▴
#74 Satellite Nickname Not escaped for PANGO
Several places in the code, the satellite nickname is marked up and used in the gui. These include menus, popups, and tooltips.
Normally this is not a problem except for a few satellites whos name contain an ampersand. Examples of this include PICOSAT 1 & 2 [TETHERED],IDEFIX & ARIANE 42P R/B,RUBIN-3 & SL-8 R/B, and RUBIN-2 & SAFIR-M. These result in the following warning being written.
Pango-WARNING **: pango_layout_set_markup_with_accel: Error on line 1: Entity did not end with a semicolon; most likely you used an ampersand character without intending to start an entity - escape ampersand as &
There is a patch for most of these coming shortly. However, this is to offer the module as a tool for future debugging. ampersands.mod includes these satellites.
Module for satellite with ampersands in the nickname
SVN commit 959 and 960 address this.
It adds an escaped nickname field to the sat_t structure and replaces the sat->nickname with the new field when the value is being marked up. This made more sense than escaping many places in the code.
Marking Fixed but waiting until 1.4 to mark closed.
Sorry, but I think it was a bad idea to add a new field to the sat_t structure for this purpose since:
(1) It is practically a copy of nickname and in most cases it will be a 1:1 copy
(2) The problem is not with nickname itself but with the GUI not being able to render it.
Therefore, I think the obvious place to fix this is in the GUI where the problem occurs and not in the data structure. SVN commit 961 shows how.
In the future, please allow more time between bug opened and non-trivial fix committed so we have a chance to express opinions, if we have any. There is no need to rush things through.
That is a better solution. I was unaware of the function. Basically the delay was time it took to code it.