#106 Additional Canon EOS 5D Mark III PTP property enum values added

[Joe On Hotmail]

Thanks for the great work on gphoto. I have a Canon EOS 5D Mark iii and I've made some changes to the libgphoto2-2.5.3 ptp module to add some missing enum values for the 5DM3. It would be great to get these into the mainline. I made a patch file with the changes and have attached it or if that doesn't work I can do whatever you'd like me to distribute them.
The changes are:
PictureStyle gets a new value "Auto" value 0x87
Camera Output gets 4 new values
Recording Output gets 1 new value
EOS Image Format gets a few new values
Exposure compensation gets 1 new value
ISO gets 2 new values
Affected files: ptp/config.c ptp/ptp.h ptp/ptp-pack.c
Thanks
Joe

[Joe On Hotmail]

Attempting to attach a patch file ...

[Marcus Meissner]

THanks!

I have applied parts of it.

The enumeration of readonly values I have to think about, there might be something easier

[Joe On Hotmail]

Are you referring to the disabled setting stuff? or something else?
Incidentally on the 5DM3, when setting the camera to Tv (shutter) exposure mode, the apterture property becomes read-only with no list, but it would still be nice to report the value with the correct enumeration even though its not settable.
If you do something to allow readonly values to be reported with the correct enum values, that would be great. In general, I wanted to make as few changes as possible as I have no idea how other cameras would be affected.
Cheers!

[Joe On Hotmail]

One more thing. Currently I'm unable to initiate a movie recording on the camera. The 5DM3 has a different button from the shutter release for starting/stopping a recording. Indeed, you can take a photo while recording.
How would this best be added? And how would one find out the command. I tried using USBlzer coupled with Canon's EOS Utility to try to capture the packets sent between the camera and Canon's app to no avail.

Joe

[Marcus Meissner]

why did you change the "output" name? we try to keep names and values consistent across camera brands , and i dont see overlap so far?

[Joe On Hotmail]

That makes sense. I had changed it just to make certain that I was updating the correct set of enums.

[Marcus Meissner]

I have applied it. I changed the name of the disabled entry a bit to be translatable easier.