[Gpe4gtk-bugs] [ gpe4gtk-Bugs-1409837 ] field attributes have bad default

[SourceForge.net <no...@so...>]

Bugs item #1409837, was opened at 2006-01-19 14:39
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=754498&aid=1409837&group_id=143095

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: incarnation database
Group: gtk4
Status: Open
Resolution: None
Priority: 5
Submitted By: Nikolay Malyshev (nbmalysh)
Assigned to: Alexander Lukichev (lukichev)
Summary: field attributes have bad default

Initial Comment:
Value by default for attributes of a field are 
established incorrectly.


<?xml version="1.0" ?>

<idb:Incarnations xmlns:idb="http://gpe.intel.com/idb">

  <idb:Template name="Empty" isPublic="true">
  </idb:Template>
  <idb:Template name="Echo">
    <idb:Field name="TEXT" isPublic="false" 
isSettable="true">
    </idb:Field>
    <idb:Field name="TEXT2">
    </idb:Field>
  </idb:Template>
</idb:Incarnations>

junit.framework.AssertionFailedError: 
IncarnationsTest.testAttributes(default of isPublic 
Field) failed expected:<true> but was:<false>
	at junit.framework.Assert.fail(Assert.java:47)
	at junit.framework.Assert.failNotEquals
(Assert.java:282)
	at junit.framework.Assert.assertEquals
(Assert.java:64)
	at junit.framework.Assert.assertEquals
(Assert.java:149)
	at 
com.intel.gpe.tests.func.idb.IncarnationsTest.testAttri
butes(IncarnationsTest.java:188)
	at 
com.intel.gpe.tests.func.idb.IncarnationsTest.main
(IncarnationsTest.java:88)
Exception in thread "main"

Suggested fix:
--------------
diff -u -r1.6 W3CElementFieldReader.java
--- W3CElementFieldReader.java	14 Nov 2005 10:37:50 -
0000	1.6
+++ W3CElementFieldReader.java	19 Jan 2006 11:29:57 -
0000
@@ -55,12 +55,12 @@
 
 	public boolean isPublic() {
 		return ElementUtil.getAttributeValue
(element, 
-			
	XMLIDBConstants.IS_PUBLIC_ATTR, "").equals
("true");
+			
	XMLIDBConstants.IS_PUBLIC_ATTR, "true").equals
("true");
 	}
 
 	public boolean isSettable() {
 		return ElementUtil.getAttributeValue
(element, 
-			
	XMLIDBConstants.IS_SETTABLE_ATTR, "").equals
("true");
+			
	XMLIDBConstants.IS_SETTABLE_ATTR, "true").equal
s("true");
 	}
 
 	
Result after fix:
-----------------
<?xml version="1.0" ?>

<idb:Incarnations xmlns:idb="http://gpe.intel.com/idb">

  <idb:Template name="Empty" isPublic="true">
  </idb:Template>
  <idb:Template name="Echo">
    <idb:Field name="TEXT" isPublic="false" 
isSettable="true">
    </idb:Field>
    <idb:Field name="TEXT2">
    </idb:Field>
  </idb:Template>
</idb:Incarnations>

IncarnationsTest.testAttributes is OK


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=754498&aid=1409837&group_id=143095