Menu

#306 wrong order in donfigure openhevc detection script

v1.0 (example)
closed-fixed
nobody
None
5
2014-10-23
2014-03-16
sL1pKn07
No

Hi

the configure script, in the openhevc detection, have a wrong flags order for detect if openHEVC has installed

----------------------snip--------------------------
if $cc -o $TMPO $TMPC $ohevc_cflags $LDFLAGS $ohevc_ldflags 2> /dev/null ; then
has_openhevc="yes"
else
ohevc_cflags="-I$local_inc"
ohevc_ldflags="-lLibOpenHevcWrapper -lpthread -lm"
if $cc -o $TMPO $TMPC $ohevc_cflags $LDFLAGS -L$local_lib $ohevc_ldflags 2> /dev/null ; then
has_openhevc="yes"
ohevc_ldflags="-L../../$local_lib $ohevc_ldflags"
fi
fi
---------------------/snip--------------------------

this fail if LDFLAGS is set with "--as-needed", because $LDFLAGS is set before $ohevc_ldflags

change this order, like:

"if $cc -o $TMPO $TMPC $ohevc_cflags $ohevc_ldflags $LDFLAGS 2> /dev/null ; then"

solve the problem

steps to reproduce:

  • install openhevc
  • set LDFLAGS with LDFLAGS="-Wl,-O1,--sort-common,--as-needed,-z,relro"
  • run gpac configure
  • see the configure output, in openhevc detection: "OpenHEVCDecoder: no"

greetings

Discussion

  • sL1pKn07

    sL1pKn07 - 2014-03-16

    ag, typo in topic, shi*

     
  • Jean Le Feuvre

    Jean Le Feuvre - 2014-10-23
    • status: open --> closed-fixed
     
  • Jean Le Feuvre

    Jean Le Feuvre - 2014-10-23

    this should have been fixed some time ago on SVN

     

Log in to post a comment.