#1363 GO Contact Sync Mod can't find Outlook contacts and calendar folders, even default ones

[Basil Peace]

GO Contact Sync Mod can't find Outlook contacts and calendar folders, even default ones.
Log says:

DBG Exception

System.Exception: Outlook contact folder is not selected or invalid!
   at GoContactSyncMod.SettingsForm.FillSyncFolderItems() in C:\Users\saller\Source\googlesyncmod\trunk\GoogleContactsSync\SettingsForm.cs:line 412
   at GoContactSyncMod.SettingsForm.ShowForm() in C:\Users\saller\Source\googlesyncmod\trunk\GoogleContactsSync\SettingsForm.cs:line 1536

Looking in the code, I found out that there is a filter which stops recursion if a folder has DefaultItemType other than olContactItem or olAppointmentItem.
This is my case: Contacts and Calendar folders are located inside another folder, which has DefaultItemType = olMailItem.
IMO, DefaultItemType is applicable to the folder itself, it isn't inherited by its children. Anyway, it's just the default.

Please consider:

• either removing these filters and scan all folders
• or, at least, separately adding default folders, whenever they are located

[Basil Peace]

Patch that solves this issue for me. Please consider merging it

[Florian Saller]

patch cannot be used, because otherwise it will scan through all folders, even multiple recursive folders within mails, and this will cause big performance lag in case of big folder structures. But I used the second proposal to add default folders on demand. If there are any contacts or appointments below a calendar folder, please move them up to a root folder with type Appointments/Calendar or Contacts, so that it can be properly scanned thrugh. The version covering this will be 4.2.1