Menu

#1356 Reminders for past events not synced

open
nobody
None
2022-08-16
2022-08-08
eranl
No

Reminders for non-recurring events whose start time is in the past are never synced. This is explicitly written in the code.
What's the reason for this exclusion?
I have a fix that syncs all reminders if SyncReminders is on. Should I commit it?

Discussion

  • Florian Saller

    Florian Saller - 2022-08-09

    no, please don't change this default behavior. this was implemented by intention, because if you sync reminders of past events, you would immediately show lots of reminders, which are not relevant anymore, and the user is bothered by reminders of events, he already performed. if really needed, add an option "sync past reminders" per default switched off and depending on "sync reminders"

     

    Last edit: Florian Saller 2022-08-09
  • eranl

    eranl - 2022-08-09

    It can potentially bother users on initial sync. OTOH, a scenario that is very common for me, and I suspect others too, is that I create a reminder for myself on the go in order to get it in my Outlook, and by the time I get home and sync, it's already in the past. That's how I came across this issue.

     
  • eranl

    eranl - 2022-08-11

    Sounds good, I'll add a setting. What's preferred:
    a. a new dependent checkbox, or
    b. replacing the current checkbox with a "sync reminders" drop-down with the following values:
    1. none
    2. future only
    3. all

    The drop-down would be backward-compatible, by recognizing "False" and "True" as valid registry values representing options 1 & 2 respectively.
    
     
  • Florian Saller

    Florian Saller - 2022-08-15

    I would go for the option a: new dependent checkbox "Sync past reminders" (or similar)
    default: unticked (backward compliant)

     
  • eranl

    eranl - 2022-08-16

    Just committed https://sourceforge.net/p/googlesyncmod/code/1580/ (with a follow-up typo fix :( ). Please review.

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.