#422 bzip2 Makefile has wrong value for VERSION

[William Bresler]

In the Makefile for bzip2, one of the modifications for GnuWin32 support defines a new variable VERSION. In the recent release for bzip2 1.0.5 VERSION is still set to 1.0.4.

Following the chain of usage, variables MAJOR and MINOR are defined to be the first and second parts, respectively, of VERSION where an optional leading zero of the second part is stripped. Thus, MAJOR=1 and MINOR=0. This eventually becomes two arguments to the linker to set the image major and minor version numbers, which can be seen in the PE header of the executables.

So, since the change from 1.0.4 to 1.0.5 just altered the patch level rather than MAJOR or MINOR, the "bug" doesn't manifest in the deliverables. However, it is confusing to a casual reader of the Makefile.

Also, in the Windows resource files for the EXEs and DLLs, it might be a good idea to update the VER_LICENSE_STR value. It still refers to the 1.0.2 release of 30 Dec 2001 and gives copyright years of 1996-2002. The up-to-date values would reflect the 1.0.5 release of 10 Dec 2007 and copyright years of 1996-2007, as can be seen in the output of bzip2 -L.

It's great to have all the relevant info in the Windows file version structure but it would be even better if the values reflected the current release.