Git Repository Merge Request #34: improve history file support (open)

The patch is to make history function independent of readline. Also fix build error when enabling builtin readline but disabling history file. And can use the history file even when disabling all readlines (including the builtin one).

[Ethan Merritt]

With these commits in place, after "./configure --without-readline" the build fails with the following error sequence:

term.c: In function ‘term_waitforinput’:
term.c:1468:9: warning: implicit declaration of function ‘raw’ [-Wimplicit-function-declaration]
 1468 |         raw();
      |         ^~~
term.c:1469:20: error: called object ‘nextchar’ is not a function or function pointer
 1469 |         nextchar = nextchar();
      |                    ^~~~~~~~
term.c:1461:9: note: declared here
 1461 |     int nextchar;
      |         ^~~~~~~~
term.c:1476:13: warning: implicit declaration of function ‘cook’ [-Wimplicit-function-declaration]
 1476 |             cook();
      |             ^~~~
term.c:1483:29: error: called object ‘nextchar’ is not a function or function pointer
 1483 |             if ((nextchar = nextchar()) == '[') {
      |                             ^~~~~~~~
term.c:1461:9: note: declared here
 1461 |     int nextchar;
      |         ^~~~~~~~
term.c:1484:28: error: called object ‘nextchar’ is not a function or function pointer
 1484 |                 nextchar = nextchar();
      |                            ^~~~~~~~
term.c:1461:9: note: declared here
 1461 |     int nextchar;
      |         ^~~~~~~~
make[2]: *** [Makefile:1030: term.o] Error 1

It probably wants something like

diff --git a/src/term.c b/src/term.c
index 9de99a7f8..da137b8c0 100644
--- a/src/term.c
+++ b/src/term.c
@@ -1453,6 +1453,10 @@ null_dashtype(int type, t_dashtype *custom_dash_pattern)
   #define raw() set_termio()
   #define cook() reset_termio()
   #define nextchar() fgetc(stdin)
+#else
+  #define raw()
+  #define cook()
+  #define nextchar() fgetc(stdin)
 #endif

 int

[PuQ]

Thank you for the fix.

By the way, there are some HAVE_WINEDITLINE in the codebase, but it doesn't seem to be in any config files. Does gnuplot actually support it?

src/history.c
301:#if defined(READLINE) || defined(HAVE_WINEDITLINE)

src/gp_hist.h
52:#elif defined(HAVE_LIBEDITLINE) || defined(HAVE_WINEDITLINE)
53-/* NetBSD editline / WinEditLine

src/syscfg.h
373:#if defined(READLINE) || defined(HAVE_LIBREADLINE) || defined(HAVE_LIBEDITLINE) || defined(HAVE_WINEDITLINE)

[Ethan Merritt]

By the way, there are some HAVE_WINEDITLINE in the codebase, but it doesn't seem to be in any config files. Does gnuplot actually support it?

There is an editline library implementation for Windows with that name. I don't know whether any of the gnuplot Windows builds use it, or used it in the past.