#2182 MS Windows, wxt terminal, window is resized on plot command after snapping

[J Scott Berg]

This is new with 5.2.7, it wasn't a problem on 5.2.6. Platform is Windows 10.

To reproduce, make a plot, then snap it to the top left of the screen (Win-Left, Win-Up). Now issue the plot command again. The window will be resized back to what it was before it was snapped.

[Tatsuro MATSUOKA]

Confirmed in 5.2.7 and the latest 5.3 (2019-06-11).
However, I am a mere package manager of windows vesion of gnuplot.
Perhaps, other persons reply to this matter.

[Tatsuro MATSUOKA]

The commit [725795] (2019-01-15 20:28:09 ) for 5.2 and 5.3 is breaking point.

--- a/src/wxterminal/wxt_gui.cpp
+++ b/src/wxterminal/wxt_gui.cpp
@@ -392,6 +392,12 @@
 #endif
    window->frame = new wxtFrame( window->title, window->id );
    window->frame->Show(true);
+#ifdef __WXMSW__
+   // If gnuplot is invoked "hidden", the very first Show() is ignored.
+   if (!window->frame->IsShown())
+       window->frame->Show(true);
+#endif
+

But if I revert the above change in 5.2.7, the issue still happens. There seems also other points for the issue.

[Tatsuro MATSUOKA]

@@ -3315,9 +3321,8 @@
        gdk_window_raise(gtk_widget_get_window(window->frame->GetHandle()));
 #else
 #ifdef __WXMSW__
-       // Only restore the window if it is iconized.  In particular
-       // leave it alone if it is maximized.
-       if (window->frame->IsIconized())
+       // Only restore the window if it is not maximized.
+       if (!(window->frame->IsMaximized()))

This change is an origin of the isse.
If I revert this change, the issue is disapeared.
But the chage is essestial for fixing the Bugs #1986 and #2116.

[Bastian Märkisch]

Confirmed. This change is the root of this new issue, but solved [#1986] and [#2116].
Reverting it only will make the old bug appear again. I now checked in a different solution
to the original problem for 5.3. Will be applied to 5.2 if confirmed to work.

[Tatsuro MATSUOKA]

Comfimed fix for this case (#2182) in 5.3.