Menu

#88 Allow to explicitely set build date

Unstable (example)
closed-fixed
nobody
None
5
2016-10-20
2015-12-11
No

Hi,

in Debian, there are ongoing efforts to make binary packages reproducably buildable. Gnudatalanguage uses during the build the __DATE__ variable which prevents the reproducibility. A patch is attached that allows to use -DBUILD_DATE="\"Dec 10 2015\"" (which is taken from our last changelog entry), ovverriding the default current date.

Would you consider applying this simple patch?

Thanks

Best regards

Ole

1 Attachments

Discussion

  • Alain C.

    Alain C. - 2015-12-11

    I will put it in the CVS ASAP (now), but I have a message at the CMAKE level:
    (cmake version 2.8.12.2)

    CMake Warning:
    Manually-specified variables were not used by the project:

    BUILD_DATE
    
     
  • Alain C.

    Alain C. - 2015-12-11
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,6 +1,6 @@
     Hi,
    
    -in Debian, there are ongoing efforts to make binary packages [reproducably buildable](http://https://wiki.debian.org/ReproducibleBuilds). Gnudatalanguage uses during the build the `__DATE__` variable which prevents the reproducibility. A patch is attached that allows to use `-DBUILD_DATE="\"Dec 10 2015\""` (which is taken from our last changelog entry), ovverriding the default current date.
    +in Debian, there are ongoing efforts to make binary packages [reproducably buildable](https://wiki.debian.org/ReproducibleBuilds). Gnudatalanguage uses during the build the `__DATE__` variable which prevents the reproducibility. A patch is attached that allows to use `-DBUILD_DATE="\"Dec 10 2015\""` (which is taken from our last changelog entry), ovverriding the default current date.
    
     Would you consider applying this simple patch?
    
     
  • Alain C.

    Alain C. - 2015-12-11

    done in the CVS but passing the date via -DBUILD_DATE= is not working for me

     
  • Ole Streicher

    Ole Streicher - 2015-12-22

    You should make sure that you correctly escape the double colons. It works fine for me as shown ion the following build log:

    /usr/bin/c++   -DHAVE_CONFIG_H -DWXUSINGDLL -D_FILE_OFFSET_BITS=64 \
    -D__WXGTK__ -Dgdl_EXPORTS -I/build/gnudatalanguage-0.9.5/src \
    -I/usr/include/GraphicsMagick \
    -I/usr/lib/x86_64-linux-gnu/wx/include/gtk2-unicode-3.0 \
    -I/usr/include/wx-3.0 -I/usr/include/hdf5/serial \
    -I/usr/include/hdf -I/usr/include/python2.7 \
    -I/usr/lib/python2.7/dist-packages/numpy/core/include \
    -I/usr/include/eigen3 -I/build/gnudatalanguage-0.9.5 \
    -I/build/gnudatalanguage-0.9.5/obj-x86_64-linux-gnu  -g -O2 \
    -fstack-protector-strong -Wformat -Werror=format-security \
    -DBUILD_DATE="\"Dec 13 2015\"" -D_FORTIFY_SOURCE=2  -fPIC   -fopenmp \
    -o CMakeFiles/gdl.dir/list.cpp.o -c \
    /build/gnudatalanguage-0.9.5/src/list.cpp
    
     

    Last edit: Ole Streicher 2015-12-22
  • giloo

    giloo - 2016-10-20
    • status: open --> closed-fixed
     

Log in to post a comment.